You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/10/19 15:15:13 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1505: HDDS-4328. Provide fallback cache restore key
adoroszlai opened a new pull request #1505:
URL: https://github.com/apache/hadoop-ozone/pull/1505
## What changes were proposed in this pull request?
Specify fallback cache restore key (`restore-keys`) for GitHub Actions CI workflow.
Maven dependency cache hit or miss in GitHub Actions workflow is based on the
hash of all POM files. If any POM is changed, all dependencies need to be
downloaded from scratch. The fallback key allows it to use one of the previous
caches, potentially avoiding most of the downloads ([doc](https://docs.github.com/en/free-pro-team@latest/actions/guides/caching-dependencies-to-speed-up-workflows#matching-a-cache-key)).
https://issues.apache.org/jira/browse/HDDS-4328
## How was this patch tested?
Regular CI in two steps.
Initial [commit](https://github.com/adoroszlai/hadoop-ozone/commit/582d89af0009e909fbcbaf82e359d0068924de79):
```
key: maven-repo-91e13458cfebf5c61e6f829853e6d98af55898ed81a5ad0b4e855c96fc0fe0ce
restore-keys: maven-repo-
Cache not found for input keys: maven-repo-91e13458cfebf5c61e6f829853e6d98af55898ed81a5ad0b4e855c96fc0fe0ce, maven-repo-
...
Post job cleanup.
Cache saved successfully
```
Next [commit](https://github.com/adoroszlai/hadoop-ozone/commit/45730362fab01d9a0ed4bcf62b1f6ac8dec5c965), with POM changes:
```
key: maven-repo-5fb5c783db98f682a1b3f4926097ed49d2297d6ee0118ace1d994e545b0259bd
restore-keys: maven-repo-
...
Cache restored from key: maven-repo-91e13458cfebf5c61e6f829853e6d98af55898ed81a5ad0b4e855c96fc0fe0ce
```
The second commit encountered cache miss, but restored from previous version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #1505: HDDS-4328. Provide fallback cache restore key
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1505:
URL: https://github.com/apache/hadoop-ozone/pull/1505
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1505: HDDS-4328. Provide fallback cache restore key
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1505:
URL: https://github.com/apache/hadoop-ozone/pull/1505#issuecomment-712751567
Thanks @vivekratnavel for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org