You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/26 16:35:40 UTC

[GitHub] [airflow] marinajpereira opened a new pull request #6196: Kubernetes Pod Operator should support init containers.

marinajpereira opened a new pull request #6196: Kubernetes Pod Operator should support init containers.
URL: https://github.com/apache/airflow/pull/6196
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - \[AIRFLOW-3152\] Kubernetes Pod Operator should support init containers.
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   This PR introduces init-containers in the kubernetes pod operator. An InitContainer (K8SModel) resource is added to ease the configuration of the init-container in the dag file. For now, InitContainer allows for configuration of the following: name, image, init_environment, volume_mounts, cmds, args. Based on the usecase at my company, the above InitContainer configuration options have sufficed. If more configuration options are required, they could added in subsequent PRs.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   tests/kubernetes/test_init_container.py that contains 2 unit tests for InitContainer
   tests/minikube/test_kubernetes_pod_operator.py - Already existed.  Added an additional test for init-container
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services