You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/08/05 04:32:58 UTC

[GitHub] [incubator-doris] luozenglin commented on a change in pull request #6374: [BUG] Fix query failure caused by using case-insensitive system view names in information_schema.

luozenglin commented on a change in pull request #6374:
URL: https://github.com/apache/incubator-doris/pull/6374#discussion_r683083208



##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
##########
@@ -618,10 +617,6 @@ public SlotDescriptor registerColumnRef(TableName tblName, String colName) throw
         if (newTblName == null) {

Review comment:
       When `newTblName ` is not empty, pass`newTblName ` to `resolveColumnRef()` to construct `TupleDescriptor

##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
##########
@@ -553,7 +552,7 @@ public TableRef resolveTableRef(TableRef tableRef) throws AnalysisException {
             ErrorReport.reportAnalysisException(ErrorCode.ERR_BAD_TABLE_STATE, "RESTORING");
         }
 
-        TableName tblName = new TableName(database.getFullName(), table.getName());
+        TableName tblName = new TableName(dbName, tableName.getTbl());

Review comment:
       `tableName.getTbl()` stores the table name specified by the user in the `from` statement. In the case of case-sensitive table names, the value of `tableName.getTbl()` is the same as `table.getName()`. However, since the system view is not case-sensitive, `table.getName()` gets the lowercase view name, which may not be the same as the user's reference to the table name, causing the table name not to be found in registerColumnRef().




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org