You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by merrimanr <gi...@git.apache.org> on 2016/01/26 02:26:00 UTC
[GitHub] incubator-metron pull request: Deployment
GitHub user merrimanr opened a pull request:
https://github.com/apache/incubator-metron/pull/14
Deployment
This pull request contains the Ansible deployment scripts. Currently the scripts support 2 deployment types: deploying Metron to a single node VM (full install including Ambari and cluster) for development and testing purposes and deploying Metron to a cluster that already exists. The Pcap source works end to end and other sources will be added in future iterations.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron deployment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit bafa055802cfb3bbb19d74fdcac669bdd48dac6e
Author: rmerriman <rm...@hortonworks.com>
Date: 2016-01-22T22:18:02Z
Added ability to configure a topic for each source
commit dc7f8a8b6ef59108ac7c5004875f7c51e48f3164
Author: rmerriman <rm...@hortonworks.com>
Date: 2016-01-22T23:47:39Z
Ansible and vagrant scripts to deploy Metron
commit b1a772313c36c4c8fb254db9a6914b47c2d081bb
Author: rmerriman <rm...@hortonworks.com>
Date: 2016-01-25T16:32:20Z
Revert "Added ability to configure a topic for each source"
This reverts commit bafa055802cfb3bbb19d74fdcac669bdd48dac6e.
commit cacb1cf85e945d65f729c8ddaf05ba1ae86a3731
Author: rmerriman <rm...@hortonworks.com>
Date: 2016-01-25T20:12:39Z
Moved hadoop setup tasks to separate role and updated documentation
commit 4da5cc4eb9ce60eb752b7c26225b32d819aae901
Author: rmerriman <rm...@hortonworks.com>
Date: 2016-01-25T20:54:03Z
Removed redundant HBase create
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Deployment
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the pull request:
https://github.com/apache/incubator-metron/pull/14#issuecomment-175051541
This is no longer valid so creating a new pull request now that we have METRON-2 in the commit history.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Deployment
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr closed the pull request at:
https://github.com/apache/incubator-metron/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Deployment
Posted by dbhirko <gi...@git.apache.org>.
Github user dbhirko commented on the pull request:
https://github.com/apache/incubator-metron/pull/14#issuecomment-174782109
A significant part of this code is from another pending pull request from a different committer. If you have additional code to use, pull the prior pull request into a branch thereby preserving the original author's commits, and you can commit on top of that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-metron pull request: Deployment
Posted by Mark Bittmann <ma...@b23.io>.
Thanks a lot Ryan for refactoring to include the original pull request. I really appreciate you taking the time to do that. I will carve out some time this week to go through the new code and test it.
On 1/26/16, 1:32 PM, "Ryan Merriman" <rm...@hortonworks.com> wrote:
>Here is the new pull request with the modifications:
>
>https://github.com/apache/incubator-metron/pull/15
>
>
>This only includes the additions our team contributed since METRON-2.
>
>On 1/26/16, 8:39 AM, "Ryan Merriman" <rm...@hortonworks.com> wrote:
>
>>Mark,
>>
>>We went back and merged METRON-2 into the master branch so your pull
>>request is in the commit history now. Let me know if something doesn’t
>>look right. I am going to add the most recent deployment changes on top
>>of that and submit a new pull request. We would love your feedback since
>>you are experienced with Ansible.
>>
>>
>>Sorry for the misunderstanding. Some of us are new to this process and
>>the fact that your pull request didn’t get merged before the big refactor
>>tripped us up.
>>
>>Ryan Merriman
>>
>>On 1/25/16, 8:54 PM, "Ryan Merriman" <rm...@hortonworks.com> wrote:
>>
>>>Really sorry about that Mark. I was so focused on getting everything
>>>working that I wasn¹t thinking about the commit history. I will get that
>>>fixed. I promise it wasn¹t intentional.
>>>
>>>On 1/25/16, 8:27 PM, "Mark Bittmann" <ma...@b23.io> wrote:
>>>
>>>>Ryan,
>>>>
>>>>It looks like you took all the code from PR #3 resubmitted it as your
>>>>own
>>>>in PR #14. Obviously you put in a ton of extra work on top of it, and
>>>>I'm
>>>>excited to see you build off of it, but I would be personally
>>>>disappointed to not get any credit for laying the foundation for all of
>>>>the Hadoop components.
>>>>
>>>>https://github.com/apache/incubator-metron/pull/3
>>>>
>>>>I would think it would be better for the community to have multiple
>>>>people contributing incrementally. Wouldn't it make more sense to pull
>>>>in
>>>>PR #3 rather than copying the code into a new PR and losing the history?
>>>>
>>>>Mark
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>On 1/25/16, 8:38 PM, "merrimanr" <gi...@git.apache.org> wrote:
>>>>
>>>>>Github user merrimanr commented on the pull request:
>>>>>
>>>>>
>>>>>https://github.com/apache/incubator-metron/pull/14#issuecomment-1747614
>>>>>3
>>>>>3
>>>>>
>>>>> https://issues.apache.org/jira/browse/METRON-21
>>>>>
>>>>>
>>>>>---
>>>>>If your project is set up for it, you can reply to this email and have
>>>>>your
>>>>>reply appear on GitHub as well. If your project does not have this
>>>>>feature
>>>>>enabled and wishes so, or if the feature is enabled but not working,
>>>>>please
>>>>>contact infrastructure at infrastructure@apache.org or file a JIRA
>>>>>ticket
>>>>>with INFRA.
>>>>>---
>>>
>>>
>>
>
Re: [GitHub] incubator-metron pull request: Deployment
Posted by Ryan Merriman <rm...@hortonworks.com>.
Here is the new pull request with the modifications:
https://github.com/apache/incubator-metron/pull/15
This only includes the additions our team contributed since METRON-2.
On 1/26/16, 8:39 AM, "Ryan Merriman" <rm...@hortonworks.com> wrote:
>Mark,
>
>We went back and merged METRON-2 into the master branch so your pull
>request is in the commit history now. Let me know if something doesn’t
>look right. I am going to add the most recent deployment changes on top
>of that and submit a new pull request. We would love your feedback since
>you are experienced with Ansible.
>
>
>Sorry for the misunderstanding. Some of us are new to this process and
>the fact that your pull request didn’t get merged before the big refactor
>tripped us up.
>
>Ryan Merriman
>
>On 1/25/16, 8:54 PM, "Ryan Merriman" <rm...@hortonworks.com> wrote:
>
>>Really sorry about that Mark. I was so focused on getting everything
>>working that I wasn¹t thinking about the commit history. I will get that
>>fixed. I promise it wasn¹t intentional.
>>
>>On 1/25/16, 8:27 PM, "Mark Bittmann" <ma...@b23.io> wrote:
>>
>>>Ryan,
>>>
>>>It looks like you took all the code from PR #3 resubmitted it as your
>>>own
>>>in PR #14. Obviously you put in a ton of extra work on top of it, and
>>>I'm
>>>excited to see you build off of it, but I would be personally
>>>disappointed to not get any credit for laying the foundation for all of
>>>the Hadoop components.
>>>
>>>https://github.com/apache/incubator-metron/pull/3
>>>
>>>I would think it would be better for the community to have multiple
>>>people contributing incrementally. Wouldn't it make more sense to pull
>>>in
>>>PR #3 rather than copying the code into a new PR and losing the history?
>>>
>>>Mark
>>>
>>>
>>>
>>>
>>>
>>>
>>>On 1/25/16, 8:38 PM, "merrimanr" <gi...@git.apache.org> wrote:
>>>
>>>>Github user merrimanr commented on the pull request:
>>>>
>>>>
>>>>https://github.com/apache/incubator-metron/pull/14#issuecomment-1747614
>>>>3
>>>>3
>>>>
>>>> https://issues.apache.org/jira/browse/METRON-21
>>>>
>>>>
>>>>---
>>>>If your project is set up for it, you can reply to this email and have
>>>>your
>>>>reply appear on GitHub as well. If your project does not have this
>>>>feature
>>>>enabled and wishes so, or if the feature is enabled but not working,
>>>>please
>>>>contact infrastructure at infrastructure@apache.org or file a JIRA
>>>>ticket
>>>>with INFRA.
>>>>---
>>
>>
>
Re: [GitHub] incubator-metron pull request: Deployment
Posted by Ryan Merriman <rm...@hortonworks.com>.
Mark,
We went back and merged METRON-2 into the master branch so your pull
request is in the commit history now. Let me know if something doesn’t
look right. I am going to add the most recent deployment changes on top
of that and submit a new pull request. We would love your feedback since
you are experienced with Ansible.
Sorry for the misunderstanding. Some of us are new to this process and
the fact that your pull request didn’t get merged before the big refactor
tripped us up.
Ryan Merriman
On 1/25/16, 8:54 PM, "Ryan Merriman" <rm...@hortonworks.com> wrote:
>Really sorry about that Mark. I was so focused on getting everything
>working that I wasn¹t thinking about the commit history. I will get that
>fixed. I promise it wasn¹t intentional.
>
>On 1/25/16, 8:27 PM, "Mark Bittmann" <ma...@b23.io> wrote:
>
>>Ryan,
>>
>>It looks like you took all the code from PR #3 resubmitted it as your own
>>in PR #14. Obviously you put in a ton of extra work on top of it, and I'm
>>excited to see you build off of it, but I would be personally
>>disappointed to not get any credit for laying the foundation for all of
>>the Hadoop components.
>>
>>https://github.com/apache/incubator-metron/pull/3
>>
>>I would think it would be better for the community to have multiple
>>people contributing incrementally. Wouldn't it make more sense to pull in
>>PR #3 rather than copying the code into a new PR and losing the history?
>>
>>Mark
>>
>>
>>
>>
>>
>>
>>On 1/25/16, 8:38 PM, "merrimanr" <gi...@git.apache.org> wrote:
>>
>>>Github user merrimanr commented on the pull request:
>>>
>>>
>>>https://github.com/apache/incubator-metron/pull/14#issuecomment-17476143
>>>3
>>>
>>> https://issues.apache.org/jira/browse/METRON-21
>>>
>>>
>>>---
>>>If your project is set up for it, you can reply to this email and have
>>>your
>>>reply appear on GitHub as well. If your project does not have this
>>>feature
>>>enabled and wishes so, or if the feature is enabled but not working,
>>>please
>>>contact infrastructure at infrastructure@apache.org or file a JIRA
>>>ticket
>>>with INFRA.
>>>---
>
>
Re: [GitHub] incubator-metron pull request: Deployment
Posted by Ryan Merriman <rm...@hortonworks.com>.
Really sorry about that Mark. I was so focused on getting everything
working that I wasn¹t thinking about the commit history. I will get that
fixed. I promise it wasn¹t intentional.
On 1/25/16, 8:27 PM, "Mark Bittmann" <ma...@b23.io> wrote:
>Ryan,
>
>It looks like you took all the code from PR #3 resubmitted it as your own
>in PR #14. Obviously you put in a ton of extra work on top of it, and I'm
>excited to see you build off of it, but I would be personally
>disappointed to not get any credit for laying the foundation for all of
>the Hadoop components.
>
>https://github.com/apache/incubator-metron/pull/3
>
>I would think it would be better for the community to have multiple
>people contributing incrementally. Wouldn't it make more sense to pull in
>PR #3 rather than copying the code into a new PR and losing the history?
>
>Mark
>
>
>
>
>
>
>On 1/25/16, 8:38 PM, "merrimanr" <gi...@git.apache.org> wrote:
>
>>Github user merrimanr commented on the pull request:
>>
>>
>>https://github.com/apache/incubator-metron/pull/14#issuecomment-174761433
>>
>> https://issues.apache.org/jira/browse/METRON-21
>>
>>
>>---
>>If your project is set up for it, you can reply to this email and have
>>your
>>reply appear on GitHub as well. If your project does not have this
>>feature
>>enabled and wishes so, or if the feature is enabled but not working,
>>please
>>contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>>with INFRA.
>>---
Re: [GitHub] incubator-metron pull request: Deployment
Posted by Mark Bittmann <ma...@b23.io>.
Ryan,
It looks like you took all the code from PR #3 resubmitted it as your own in PR #14. Obviously you put in a ton of extra work on top of it, and I'm excited to see you build off of it, but I would be personally disappointed to not get any credit for laying the foundation for all of the Hadoop components.
https://github.com/apache/incubator-metron/pull/3
I would think it would be better for the community to have multiple people contributing incrementally. Wouldn't it make more sense to pull in PR #3 rather than copying the code into a new PR and losing the history?
Mark
On 1/25/16, 8:38 PM, "merrimanr" <gi...@git.apache.org> wrote:
>Github user merrimanr commented on the pull request:
>
> https://github.com/apache/incubator-metron/pull/14#issuecomment-174761433
>
> https://issues.apache.org/jira/browse/METRON-21
>
>
>---
>If your project is set up for it, you can reply to this email and have your
>reply appear on GitHub as well. If your project does not have this feature
>enabled and wishes so, or if the feature is enabled but not working, please
>contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>with INFRA.
>---
[GitHub] incubator-metron pull request: Deployment
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the pull request:
https://github.com/apache/incubator-metron/pull/14#issuecomment-174761433
https://issues.apache.org/jira/browse/METRON-21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request: Deployment
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the pull request:
https://github.com/apache/incubator-metron/pull/14#issuecomment-174789162
Sorry was so focused on getting it to work that I wasn't even thinking about the commit history. I will get this corrected asap.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---