[jira] [Commented] (LUCENE-6525) Deprecate IndexWriterConfig's write lock timeout

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573469#comment-14573469 ] 

Michael McCandless commented on LUCENE-6525:
--------------------------------------------

+1

> Deprecate IndexWriterConfig's write lock timeout
> ------------------------------------------------
>
>                 Key: LUCENE-6525
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6525
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>
> Followup from LUCENE-6508
> We should ultimately remove this parameter, it is just sugar over a "sleeping lock factory" today that sleeps and retries until timeout, like the old code.
> But really if you want a lock that blocks until its obtained, you can simply specify the sleeping lock factory yourself (and have more control over what it does!), or maybe an NIO implementation based on the blocking FileChannel.lock() or something else.
> So this stuff should be out of indexwriter and not baked into our APIs.
> I would like to:
> 1) deprecate this, mentioning to use the sleeping factory instead
> 2) change default of deprecated timeout to 0, so you only sleep if you ask. I am not really sure if matchVersion can be used, because today the default itself is also settable with a static setter <-- OVERENGINEERED



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org