You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/16 23:03:46 UTC

[GitHub] [arrow] keeratsingh commented on a change in pull request #7994: ARROW-9804: [FlightRPC] Flight auth redesign

keeratsingh commented on a change in pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#discussion_r506756240



##########
File path: java/flight/flight-core/src/main/java/org/apache/arrow/flight/CallOptions.java
##########
@@ -56,7 +56,7 @@ public static CallOption timeout(long duration, TimeUnit unit) {
   /**
    * CallOptions specific to GRPC stubs.
    */
-  interface GrpcCallOption extends CallOption {
+  public interface GrpcCallOption extends CallOption {

Review comment:
       @lidavidm Moving `GrpcCallOption` to `flight-grpc` adds a circular dependency since `flight-grpc` is dependent on `flight-core` for FlightProducer and FlightClient.
   
   Is the intention behind this comment to:
   - move all grpc related dependencies to `flight-grpc` module?
   - Or just move the `GrpcCallOption` to `org.apache.arrow.flight.grpc` package ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org