You are viewing a plain text version of this content. The canonical link for it is here.
Posted to sandesha-dev@ws.apache.org by ja...@apache.org on 2006/09/27 00:31:41 UTC

svn commit: r450241 - /webservices/sandesha/branches/sandesha_1_0/src/org/apache/sandesha/server/msgprocessors/AcknowledgementProcessor.java

Author: jaliya
Date: Tue Sep 26 15:31:41 2006
New Revision: 450241

URL: http://svn.apache.org/viewvc?view=rev&rev=450241
Log:
Fixed a NPE at AcknowledgementProcessor.java

Modified:
    webservices/sandesha/branches/sandesha_1_0/src/org/apache/sandesha/server/msgprocessors/AcknowledgementProcessor.java

Modified: webservices/sandesha/branches/sandesha_1_0/src/org/apache/sandesha/server/msgprocessors/AcknowledgementProcessor.java
URL: http://svn.apache.org/viewvc/webservices/sandesha/branches/sandesha_1_0/src/org/apache/sandesha/server/msgprocessors/AcknowledgementProcessor.java?view=diff&rev=450241&r1=450240&r2=450241
==============================================================================
--- webservices/sandesha/branches/sandesha_1_0/src/org/apache/sandesha/server/msgprocessors/AcknowledgementProcessor.java (original)
+++ webservices/sandesha/branches/sandesha_1_0/src/org/apache/sandesha/server/msgprocessors/AcknowledgementProcessor.java Tue Sep 26 15:31:41 2006
@@ -94,7 +94,10 @@
         }
         RMMessageContext rmMsgContext = getAckRMMsgCtx(rmMessageContext, ackRangeList);
 
-        if (true ==
+        if (null == storageManager.getAcksTo(seqID)) {
+            throw new AxisFault(Constants.FaultCodes.WSRM_SERVER_INTERNAL_ERROR +
+                    " Could not find the AcksTo in the Storage");
+        } else if (true ==
                 (storageManager.getAcksTo(seqID).equals(Constants.WSA.NS_ADDRESSING_ANONYMOUS))) {
             try {
                 String soapMsg = rmMsgContext.getMsgContext().getResponseMessage().getSOAPEnvelope()
@@ -132,7 +135,7 @@
             rmMsgContext.setOutGoingAddress(to);
             rmMsgContext.setMessageType(Constants.MSG_TYPE_ACKNOWLEDGEMENT);
         } catch (Exception e) {
-            log.error("",e);
+            log.error("", e);
         }
         return rmMsgContext;
     }
@@ -162,7 +165,8 @@
                     max = ((Long) listOfMsgNumbers.get(new Long(i))).longValue();
                 } else {
 
-                    if (1 == (((Long) listOfMsgNumbers.get(new Long(i + 1))).longValue() - ((Long) listOfMsgNumbers.get(new Long(i))).longValue())) {
+                    if (1 == (((Long) listOfMsgNumbers.get(new Long(i + 1))).longValue() - ((Long) listOfMsgNumbers.get(new Long(i))).longValue()))
+                    {
                         max = ((Long) listOfMsgNumbers.get(new Long(i + 1))).longValue();
                         found = true;
                     } else {



---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org