You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/24 13:03:01 UTC
[GitHub] [airflow] kaxil opened a new pull request #7851: Bump Boto3 to
>=1.12
kaxil opened a new pull request #7851: Bump Boto3 to >=1.12
URL: https://github.com/apache/airflow/pull/7851
Bump Boto3 to >=1.12
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on a change in pull request #7851:
Bump Boto3 to >=1.12
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #7851: Bump Boto3 to >=1.12
URL: https://github.com/apache/airflow/pull/7851#discussion_r397229678
##########
File path: setup.py
##########
@@ -182,7 +182,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'atlasclient>=0.1.2',
]
aws = [
- 'boto3~=1.10',
+ 'boto3>=1.12.0,<2.0.0',
Review comment:
Why `>=1.12.0` not `>=1.10.0` ? Is there an issue with `~=1.10` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7851: Bump
Boto3 to >=1.12
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7851: Bump Boto3 to >=1.12
URL: https://github.com/apache/airflow/pull/7851#discussion_r397253470
##########
File path: setup.py
##########
@@ -182,7 +182,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'atlasclient>=0.1.2',
]
aws = [
- 'boto3~=1.10',
+ 'boto3>=1.12.0,<2.0.0',
Review comment:
To use the newer version.
**Idea being**: Use newer version if it doesn't break anything
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7851: Bump Boto3 to >=1.12
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7851: Bump Boto3 to >=1.12
URL: https://github.com/apache/airflow/pull/7851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services