You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/04/05 19:14:16 UTC
[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1105: DISPATCH-836 Standardize #include order
jiridanek opened a new pull request #1105:
URL: https://github.com/apache/qpid-dispatch/pull/1105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1105: DISPATCH-836 Standardize #include order
Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #1105:
URL: https://github.com/apache/qpid-dispatch/pull/1105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1105: DISPATCH-836 Standardize #include order
Posted by GitBox <gi...@apache.org>.
jiridanek commented on a change in pull request #1105:
URL: https://github.com/apache/qpid-dispatch/pull/1105#discussion_r607287597
##########
File path: src/router_core/modules/address_lookup_server/address_lookup_server.c
##########
@@ -17,13 +17,14 @@
* under the License.
*/
-#include <qpid/dispatch/address_lookup_server.h>
-#include <qpid/dispatch/ctools.h>
-#include "module.h"
+#include "qpid/dispatch/address_lookup_server.h"
+
#include "core_link_endpoint.h"
+#include "module.h"
-#include "inttypes.h"
Review comment:
oh yeah, this was the second issue this uncovered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1105: DISPATCH-836 Standardize #include order
Posted by GitBox <gi...@apache.org>.
jiridanek commented on a change in pull request #1105:
URL: https://github.com/apache/qpid-dispatch/pull/1105#discussion_r607278251
##########
File path: src/router_core/exchange_bindings.c
##########
@@ -16,14 +16,16 @@
* specific language governing permissions and limitations
* under the License.
*/
-#include <qpid/dispatch/ctools.h>
-#include <inttypes.h>
-#include <stdio.h>
-#include "router_core_private.h"
-#include "forwarder.h"
#include "exchange_bindings.h"
Review comment:
Here's the only issue the reordering found. `exchange_bindings.h` depended on being included after `"router_core_private.h"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1105: DISPATCH-836 Standardize #include order
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #1105:
URL: https://github.com/apache/qpid-dispatch/pull/1105#issuecomment-813588422
This is way too big to ask anyone to review. I'll read though this few more times and go with CI result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org