Re: [PR] fix: adhoc metrics [superset]

["betodealmeida (via GitHub)" <gi...@apache.org>]

betodealmeida commented on code in PR #30202:
URL: https://github.com/apache/superset/pull/30202#discussion_r1796044017


##########
superset/sql_parse.py:
##########
@@ -1177,46 +1106,31 @@ class InsertRLSState(StrEnum):
     FOUND_TABLE = "FOUND_TABLE"
 
 
-def has_table_query(token_list: TokenList) -> bool:
+def has_table_query(expression: str, engine: str) -> bool:

Review Comment:
   I have another PR where I rewrite the RLS logic using `sqlglot`, I'll refactor `has_table_query` there to take a full statement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org