[jira] [Commented] (KAFKA-9365) Add consumer group information to producer txn commit

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-9365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008239#comment-17008239 ] 

ASF GitHub Bot commented on KAFKA-9365:
---------------------------------------

abbccdda commented on pull request #7897: KAFKA-9365: Add consumer group information to producer transaction commit for correct fencing
URL: https://github.com/apache/kafka/pull/7897
 
 
   To be able to correctly fence zombie producer txn commit, we propose to add (member.id, group.instance.id, generation) into the transaction commit protocol to raise the same level of correctness guarantee as consumer commit.
   
   Major changes involve:
   
   1. Upgrade transaction commit protocol with  (member.id, group.instance.id, generation). The client will fail if the broker is not supporting the new protocol.
   2. Refactor group coordinator logic to handle new txn commit errors such as FENCED_INSTANCE_ID, UNKNOWN_MEMBER_ID and ILLEGAL_GENERATION. We loose the check on transaction commit when the member.id is set to empty. This is because the member.id check is an add-on safety for producer commit, and we also need to consider backward compatibility for old producer clients without member.id information. And if producer equips with group.instance.id, then it must provide a valid member.id (not empty definitely), the same as a consumer commit.
   3. Add same exception handling to transaction manager client as well. Note we denote UNKNOWN_MEMBER_ID as non-fatal while denote fatal for the other two to match what currently consumer commit protocol behaves.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add consumer group information to producer txn commit 
> ------------------------------------------------------
>
>                 Key: KAFKA-9365
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9365
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Boyang Chen
>            Assignee: Boyang Chen
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)