You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by fanyon <gi...@git.apache.org> on 2017/04/24 07:43:05 UTC
[GitHub] flink pull request #3759: [FLINK-6366] close KafkaConsumer in FlinkKafkaCons...
GitHub user fanyon opened a pull request:
https://github.com/apache/flink/pull/3759
[FLINK-6366] close KafkaConsumer in FlinkKafkaConsumer09 after getKaf\u2026
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fanyon/flink FLINK-6366
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3759.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3759
----
commit cb0624f98290af800f50286d95823a8ec0efcf10
Author: mengji.fy <me...@taobao.com>
Date: 2017-04-24T07:17:54Z
[FLINK-6366] close KafkaConsumer in FlinkKafkaConsumer09 after getKafkaPartitions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3759: [FLINK-6366] close KafkaConsumer in FlinkKafkaConsumer09 ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3759
@fanyon Can you close this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3759: [FLINK-6366] close KafkaConsumer in FlinkKafkaConsumer09 ...
Posted by fanyon <gi...@git.apache.org>.
Github user fanyon commented on the issue:
https://github.com/apache/flink/pull/3759
@tzulitai I checked the try-with-resource and the consumer will be closed at the end of the statement, I will closed this issue and thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3759: [FLINK-6366] close KafkaConsumer in FlinkKafkaConsumer09 ...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3759
This change isn't necessary, as the previous implementation was a "try-with-resources" statement (see https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html).
The consumer is always closed when the try block finishes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3759: [FLINK-6366] close KafkaConsumer in FlinkKafkaCons...
Posted by fanyon <gi...@git.apache.org>.
Github user fanyon closed the pull request at:
https://github.com/apache/flink/pull/3759
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---