You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2011/05/29 00:56:48 UTC
[jira] [Created] (LUCENE-3152) MockDirectoryWrapper should wrap the
lockfactory
MockDirectoryWrapper should wrap the lockfactory
------------------------------------------------
Key: LUCENE-3152
URL: https://issues.apache.org/jira/browse/LUCENE-3152
Project: Lucene - Java
Issue Type: Bug
Components: general/test
Reporter: Robert Muir
Fix For: 3.3, 4.0
After applying the patch from LUCENE-3147, I added a line to make the test fail if it cannot remove its temporary directory.
I ran 'ant test' on linux 50 times, and it passed all 50 times.
But on windows, it failed often because of write.lock... this is because of unclosed writers in the test.
MockDirectoryWrapper is currently unaware of this write.lock, I think it should wrap the lockfactory so that .close() will fail if there are any outstanding locks.
Then hopefully these tests would fail on linux too.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3152) MockDirectoryWrapper should wrap
the lockfactory
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046652#comment-13046652 ]
Robert Muir commented on LUCENE-3152:
-------------------------------------
oops i meant to close this
> MockDirectoryWrapper should wrap the lockfactory
> ------------------------------------------------
>
> Key: LUCENE-3152
> URL: https://issues.apache.org/jira/browse/LUCENE-3152
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Reporter: Robert Muir
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3152.patch
>
>
> After applying the patch from LUCENE-3147, I added a line to make the test fail if it cannot remove its temporary directory.
> I ran 'ant test' on linux 50 times, and it passed all 50 times.
> But on windows, it failed often because of write.lock... this is because of unclosed writers in the test.
> MockDirectoryWrapper is currently unaware of this write.lock, I think it should wrap the lockfactory so that .close() will fail if there are any outstanding locks.
> Then hopefully these tests would fail on linux too.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3152) MockDirectoryWrapper should wrap
the lockfactory
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040736#comment-13040736 ]
Shai Erera commented on LUCENE-3152:
------------------------------------
This is great ! I think this one can be committed. I ran tests on my Windows machine and all passed.
> MockDirectoryWrapper should wrap the lockfactory
> ------------------------------------------------
>
> Key: LUCENE-3152
> URL: https://issues.apache.org/jira/browse/LUCENE-3152
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Reporter: Robert Muir
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3152.patch
>
>
> After applying the patch from LUCENE-3147, I added a line to make the test fail if it cannot remove its temporary directory.
> I ran 'ant test' on linux 50 times, and it passed all 50 times.
> But on windows, it failed often because of write.lock... this is because of unclosed writers in the test.
> MockDirectoryWrapper is currently unaware of this write.lock, I think it should wrap the lockfactory so that .close() will fail if there are any outstanding locks.
> Then hopefully these tests would fail on linux too.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3152) MockDirectoryWrapper should wrap
the lockfactory
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040705#comment-13040705 ]
Michael McCandless commented on LUCENE-3152:
--------------------------------------------
Patch looks great! Nice to have MDW catch un-released locks too :)
> MockDirectoryWrapper should wrap the lockfactory
> ------------------------------------------------
>
> Key: LUCENE-3152
> URL: https://issues.apache.org/jira/browse/LUCENE-3152
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Reporter: Robert Muir
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3152.patch
>
>
> After applying the patch from LUCENE-3147, I added a line to make the test fail if it cannot remove its temporary directory.
> I ran 'ant test' on linux 50 times, and it passed all 50 times.
> But on windows, it failed often because of write.lock... this is because of unclosed writers in the test.
> MockDirectoryWrapper is currently unaware of this write.lock, I think it should wrap the lockfactory so that .close() will fail if there are any outstanding locks.
> Then hopefully these tests would fail on linux too.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3152) MockDirectoryWrapper should wrap
the lockfactory
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040706#comment-13040706 ]
Robert Muir commented on LUCENE-3152:
-------------------------------------
ok, i committed to our branch... i'll keep testing with windows but I think between the two issues we have now fixed all the bugs in MockDirectoryWrapper so it consistently "acts like windows".
> MockDirectoryWrapper should wrap the lockfactory
> ------------------------------------------------
>
> Key: LUCENE-3152
> URL: https://issues.apache.org/jira/browse/LUCENE-3152
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Reporter: Robert Muir
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3152.patch
>
>
> After applying the patch from LUCENE-3147, I added a line to make the test fail if it cannot remove its temporary directory.
> I ran 'ant test' on linux 50 times, and it passed all 50 times.
> But on windows, it failed often because of write.lock... this is because of unclosed writers in the test.
> MockDirectoryWrapper is currently unaware of this write.lock, I think it should wrap the lockfactory so that .close() will fail if there are any outstanding locks.
> Then hopefully these tests would fail on linux too.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3152) MockDirectoryWrapper should wrap the
lockfactory
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-3152:
--------------------------------
Attachment: LUCENE-3152.patch
attached is a patch... all the windows-only problems i found with LUCENE-3147 now fail on linux (and are corrected in the patch)
> MockDirectoryWrapper should wrap the lockfactory
> ------------------------------------------------
>
> Key: LUCENE-3152
> URL: https://issues.apache.org/jira/browse/LUCENE-3152
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Reporter: Robert Muir
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3152.patch
>
>
> After applying the patch from LUCENE-3147, I added a line to make the test fail if it cannot remove its temporary directory.
> I ran 'ant test' on linux 50 times, and it passed all 50 times.
> But on windows, it failed often because of write.lock... this is because of unclosed writers in the test.
> MockDirectoryWrapper is currently unaware of this write.lock, I think it should wrap the lockfactory so that .close() will fail if there are any outstanding locks.
> Then hopefully these tests would fail on linux too.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3152) MockDirectoryWrapper should wrap
the lockfactory
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040848#comment-13040848 ]
Shai Erera commented on LUCENE-3152:
------------------------------------
Robert, can we close this now that LUCENE-3147 is closed?
> MockDirectoryWrapper should wrap the lockfactory
> ------------------------------------------------
>
> Key: LUCENE-3152
> URL: https://issues.apache.org/jira/browse/LUCENE-3152
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Reporter: Robert Muir
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3152.patch
>
>
> After applying the patch from LUCENE-3147, I added a line to make the test fail if it cannot remove its temporary directory.
> I ran 'ant test' on linux 50 times, and it passed all 50 times.
> But on windows, it failed often because of write.lock... this is because of unclosed writers in the test.
> MockDirectoryWrapper is currently unaware of this write.lock, I think it should wrap the lockfactory so that .close() will fail if there are any outstanding locks.
> Then hopefully these tests would fail on linux too.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3152) MockDirectoryWrapper should wrap
the lockfactory
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-3152.
---------------------------------
Resolution: Fixed
> MockDirectoryWrapper should wrap the lockfactory
> ------------------------------------------------
>
> Key: LUCENE-3152
> URL: https://issues.apache.org/jira/browse/LUCENE-3152
> Project: Lucene - Java
> Issue Type: Bug
> Components: general/test
> Reporter: Robert Muir
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3152.patch
>
>
> After applying the patch from LUCENE-3147, I added a line to make the test fail if it cannot remove its temporary directory.
> I ran 'ant test' on linux 50 times, and it passed all 50 times.
> But on windows, it failed often because of write.lock... this is because of unclosed writers in the test.
> MockDirectoryWrapper is currently unaware of this write.lock, I think it should wrap the lockfactory so that .close() will fail if there are any outstanding locks.
> Then hopefully these tests would fail on linux too.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org