EOLs in Code

[Stefan Bodewig <bo...@apache.org>]

Hi all,

a few days ago I saw  few files without license headers and wanted to
provide a patch to fix them.  I realized those files didn't have proper
line-ends and so the patch would have looked ugly (I am on Linux), I
fixed them in svn instead - don't worry, I won't start modifying code.

Anyway.  Can you please make sure the svn:eol-style property is set
correctly when you add new files to svn?  The most convenient way is by
setting up the auto-props section in your svn client's config, see
<http://www.apache.org/dev/version-control.html#https-svn-config>

Cheers

        Stefan

Re: EOLs in Code

[Itamar Syn-Hershko <it...@code972.com>]

Yes, seems like all of them. Will look into it.

On Sat, Jun 2, 2012 at 9:25 PM, Stefan Bodewig <bo...@apache.org> wrote:

> On 2012-06-02, Itamar Syn-Hershko wrote:
>
> > I'm using git-svn, with auto-crlf set to true
>
> I'm not familiar enough with git-svn.  auto-crlf will cover the git side
> but I don't think it sets the eol-style property in svn.
>
> > - I think this will cover it but let me know if my commits are bad...
>
> I think some of the files I touched with
> https://svn.apache.org/viewvc?view=revision&revision=1344562 are from
> your commit.
>
> Thanks
>
>        Stefan
>
>

Re: EOLs in Code

[Stefan Bodewig <bo...@apache.org>]

On 2012-06-02, Itamar Syn-Hershko wrote:

> I'm using git-svn, with auto-crlf set to true

I'm not familiar enough with git-svn.  auto-crlf will cover the git side
but I don't think it sets the eol-style property in svn.

> - I think this will cover it but let me know if my commits are bad...

I think some of the files I touched with
https://svn.apache.org/viewvc?view=revision&revision=1344562 are from
your commit.

Thanks

        Stefan

Re: EOLs in Code

[Itamar Syn-Hershko <it...@code972.com>]

I'm using git-svn, with auto-crlf set to true - I think this will cover it
but let me know if my commits are bad...

On Sat, Jun 2, 2012 at 6:59 PM, Stefan Bodewig <bo...@apache.org> wrote:

> Hi all,
>
> a few days ago I saw  few files without license headers and wanted to
> provide a patch to fix them.  I realized those files didn't have proper
> line-ends and so the patch would have looked ugly (I am on Linux), I
> fixed them in svn instead - don't worry, I won't start modifying code.
>
> Anyway.  Can you please make sure the svn:eol-style property is set
> correctly when you add new files to svn?  The most convenient way is by
> setting up the auto-props section in your svn client's config, see
> <http://www.apache.org/dev/version-control.html#https-svn-config>
>
> Cheers
>
>        Stefan
>
>