[GitHub] [spark] cloud-fan commented on a change in pull request #24416: [SPARK-27521][SQL] Move data source v2 to catalyst module

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24416: [SPARK-27521][SQL] Move data source v2 to catalyst module
URL: https://github.com/apache/spark/pull/24416#discussion_r289383485
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamProviderSuite.scala
 ##########
 @@ -305,7 +305,7 @@ class RateStreamProviderSuite extends StreamTest {
         .load()
     }
     assert(exception.getMessage.contains(
-      "rate source does not support user-specified schema"))
+      "RateStreamProvider source does not support user-specified schema"))
 
 Review comment:
   This is because I hesitate to move `DataSourceRegister` to catalyst, and then DS v2 is not able to get `DataSourceRegister#shorName`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org