You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by TomasHofman <gi...@git.apache.org> on 2017/06/01 07:56:23 UTC

[GitHub] activemq-artemis pull request #1298: ARTEMIS-1187 Incompatible version when ...

Github user TomasHofman commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1298#discussion_r119549290
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java ---
    @@ -686,7 +686,7 @@ protected CreateSessionMessage newCreateSession(String username,
                                                        boolean autoCommitSends,
                                                        boolean autoCommitAcks,
                                                        boolean preAcknowledge) {
    -      return new CreateSessionMessage(name, sessionChannel.getID(), VersionLoader.getVersion().getIncrementingVersion(), username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null);
    +      return new CreateSessionMessage(name, sessionChannel.getID(), serverVersion, username, password, minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, confirmationWindow, null);
    --- End diff --
    
    Thanks, I'm glad for feedback, I might have also be wrong...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---