You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by jianqiao <gi...@git.apache.org> on 2018/02/02 23:50:45 UTC

[GitHub] incubator-quickstep pull request #331: Add a cmake option to handle the Trav...

GitHub user jianqiao opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/331

    Add a cmake option to handle the Travis CI timeout problem.

    This PR adds a cmake option `ENABLE_COMPARISON_INLINE_EXPANSION` to allow disabling of method specialization in various `Comparison`'s.
    
    Turing the flag `OFF` will greatly reduce Quickstep compile time -- thus improving development productivity as well as fixing the Travis CI timeout problem. Note that the flag is by default `ON`, and will be [turned off](https://github.com/apache/incubator-quickstep/blob/539e1ebe09b5d1a2d86069ed1fdc6e9fb38c5ce7/.travis.yml#L80) during the Travis test.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-quickstep fix-travis-timeout

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #331
    
----
commit 539e1ebe09b5d1a2d86069ed1fdc6e9fb38c5ce7
Author: Jianqiao Zhu <ji...@...>
Date:   2018-02-02T23:27:59Z

    Add a flag to allow disabling of Comparison inline expansion to enable acceleration of Quickstep build.
    
    (for development productivity as well as solving the Travis CI timeout problem)

----


---

[GitHub] incubator-quickstep issue #331: Add a cmake option to handle the Travis CI t...

Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/331
  
    LGTM! Cool finding!


---

[GitHub] incubator-quickstep pull request #331: Add a cmake option to handle the Trav...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quickstep/pull/331


---