You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/01/20 20:07:20 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #5008: AVG(null) is NULL (not zero)
alamb opened a new pull request, #5008:
URL: https://github.com/apache/arrow-datafusion/pull/5008
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/5007
# Rationale for this change
Answer is incorrect
# What changes are included in this PR?
AVG nulls is null
# Are these changes tested?
yes
# Are there any user-facing changes?
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5008: AVG(null) is NULL (not zero)
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5008:
URL: https://github.com/apache/arrow-datafusion/pull/5008#issuecomment-1399215388
Benchmark runs are scheduled for baseline = 9c119961c238d8cd8e3adcf8b25238547661edae and contender = f5439c806912e69ad974706ab37456ac6bac21e4. f5439c806912e69ad974706ab37456ac6bac21e4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ecc762b5c4f343b8bd3b6feb167ea411...ad139fd807744e2ead94149eefa35726/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c78d62a83b8d41329bbd821a9668b9c6...325e43d932a543ee86105c4884b59ab9/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7dfc7a15bcf44d19a0fd3b6004478ba9...10a6b30811ac46fbaa06dba0eea8c8db/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1e47ce5433094e2c8645e782f07ea252...a97809538820410bafbafeea13192206/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5008: AVG(null) is NULL (not zero)
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5008:
URL: https://github.com/apache/arrow-datafusion/pull/5008#issuecomment-1398958976
> LGTM, this made me think of the COUNT fix we made recently. Makes me think there may be some other minor gotchas like this lying around in the code, hopefully we will fix them soon.
Yeah, I originally thought it was related to https://github.com/apache/arrow-datafusion/pull/4924#discussion_r1072918404 😆 but I think the refactor in group by simply exposed a latent issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 merged pull request #5008: AVG(null) is NULL (not zero)
Posted by "xudong963 (via GitHub)" <gi...@apache.org>.
xudong963 merged PR #5008:
URL: https://github.com/apache/arrow-datafusion/pull/5008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org