You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/10/07 17:29:43 UTC

[GitHub] [solr] madrob commented on a change in pull request #316: SOLR-15659: ObjectReleaseTracker is now in the wrong class, should le…

madrob commented on a change in pull request #316:
URL: https://github.com/apache/solr/pull/316#discussion_r724387682



##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
##########
@@ -150,6 +151,14 @@ public void checkSyspropForceBeforeAssumptionFailure() {
   
   @AfterClass
   public static void shutdownLogger() throws Exception {

Review comment:
       Feels like this method should be renamed since it is doing more than just the logger now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org