You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/06/04 08:43:27 UTC
Review Request 35046: DRILL-2089: Part 1--Pre-move preparation and
code hygiene.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35046/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2089
https://issues.apache.org/jira/browse/DRILL-2089
Repository: drill-git
Description
-------
Preparation for moving classes:
- Added missed "public" to JdbcApiSqlException and InvalidCursorStateSqlException.
Code hygiene:
- Fixed commented-out constructors. [AlreadyClosedSqlException]
- Fixed missed re-alignment. [DrillConnectionImpl]
- Fixed basic whitespace. [Driver]
- Fixed/augmented/added various doc. comments.
- Added @Override annotations. [MetaImpl, DrillJdbc41Factory]
- Purged an unused import. [DrillJdbc41Factory]
Diffs
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/AlreadyClosedSqlException.java a2a06ab
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 5f82054
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillDatabaseMetaData.java 4b2d694
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillFactory.java c674f8e
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc41Factory.java 93fe59d
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 2e3d49f
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java 56a8b7f
exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 55453e8
exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java d71248c
exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java ce83e01
exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 2ac0b91
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java 6610f52
Diff: https://reviews.apache.org/r/35046/diff/
Testing
-------
Ran existing tests. (With parts 1 through 7 together.)
Thanks,
Daniel Barclay
Re: Review Request 35046: DRILL-2089: Part 1--Pre-move preparation
and code hygiene.
Posted by Daniel Barclay <db...@maprtech.com>.
> On June 9, 2015, 6:46 p.m., Parth Chandra wrote:
> > exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java, line 114
> > <https://reviews.apache.org/r/35046/diff/1/?file=978317#file978317line114>
> >
> > Can you put the corresponding JIRA here?
Already fixed in queued-up DRILL-3198 fix.
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35046/#review87258
-----------------------------------------------------------
On June 4, 2015, 6:43 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35046/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 6:43 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2089
> https://issues.apache.org/jira/browse/DRILL-2089
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Preparation for moving classes:
> - Added missed "public" to JdbcApiSqlException and InvalidCursorStateSqlException.
>
> Code hygiene:
> - Fixed commented-out constructors. [AlreadyClosedSqlException]
> - Fixed missed re-alignment. [DrillConnectionImpl]
> - Fixed basic whitespace. [Driver]
> - Fixed/augmented/added various doc. comments.
> - Added @Override annotations. [MetaImpl, DrillJdbc41Factory]
> - Purged an unused import. [DrillJdbc41Factory]
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/AlreadyClosedSqlException.java a2a06ab
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 5f82054
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillDatabaseMetaData.java 4b2d694
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillFactory.java c674f8e
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc41Factory.java 93fe59d
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 2e3d49f
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java 56a8b7f
> exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 55453e8
> exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java d71248c
> exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java ce83e01
> exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 2ac0b91
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java 6610f52
>
> Diff: https://reviews.apache.org/r/35046/diff/
>
>
> Testing
> -------
>
> Ran existing tests. (With parts 1 through 7 together.)
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 35046: DRILL-2089: Part 1--Pre-move preparation
and code hygiene.
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35046/#review87258
-----------------------------------------------------------
Ship it!
Minor comment
exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java
<https://reviews.apache.org/r/35046/#comment139571>
Can you put the corresponding JIRA here?
- Parth Chandra
On June 4, 2015, 6:43 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35046/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 6:43 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2089
> https://issues.apache.org/jira/browse/DRILL-2089
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Preparation for moving classes:
> - Added missed "public" to JdbcApiSqlException and InvalidCursorStateSqlException.
>
> Code hygiene:
> - Fixed commented-out constructors. [AlreadyClosedSqlException]
> - Fixed missed re-alignment. [DrillConnectionImpl]
> - Fixed basic whitespace. [Driver]
> - Fixed/augmented/added various doc. comments.
> - Added @Override annotations. [MetaImpl, DrillJdbc41Factory]
> - Purged an unused import. [DrillJdbc41Factory]
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/AlreadyClosedSqlException.java a2a06ab
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionImpl.java 5f82054
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillDatabaseMetaData.java 4b2d694
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillFactory.java c674f8e
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillJdbc41Factory.java 93fe59d
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java 2e3d49f
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java 56a8b7f
> exec/jdbc/src/main/java/org/apache/drill/jdbc/Driver.java 55453e8
> exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java d71248c
> exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java ce83e01
> exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java 2ac0b91
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java cb6bd1d
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java 6610f52
>
> Diff: https://reviews.apache.org/r/35046/diff/
>
>
> Testing
> -------
>
> Ran existing tests. (With parts 1 through 7 together.)
>
>
> Thanks,
>
> Daniel Barclay
>
>