You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by davebarnes97 <gi...@git.apache.org> on 2016/10/12 16:48:00 UTC

[GitHub] incubator-geode issue #257: Feature/geode 1952

Github user davebarnes97 commented on the issue:

    https://github.com/apache/incubator-geode/pull/257
  
    Nice work! Two comments:
    1. As mentioned, I get one orphaned file during the bookbinder build: pdf_header.html.
    2. README.md sugggestions:
    a. "Bookbinder is a gem" -> "Bookbinder is a Ruby gem"
    b. Why show config.yml? Potential maintenance headache going forward.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---