You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2026/06/25 10:18:18 UTC

[PR] test(spark): de-flake TestHoodieClientMultiWriter early-conflict detection [hudi]

voonhous opened a new pull request, #19069:
URL: https://github.com/apache/hudi/pull/19069

   The early-conflict-detection test's commit-004 path waited heartBeatIntervalForCommit4 * 2 (6s) for the failed commit 003's heartbeat to expire, which assumed the default hoodie.client.heartbeat.tolerable.misses of 2 (expiry window = misses * interval = 2 * 3000 = 6000ms). #18904 raised that default to 10, growing the window to 30000ms, so commit 004 saw 003 as still alive and hit a false early conflict, failing assertDoesNotThrow.
   
   Because that failure threw before the un-finally'd TestingServer was closed, and surefire runs the shard with reuseForks=true, the leaked embedded ZooKeeper kept holding its admin server's fixed port 8080, so every later rerun failed with "Unable to instantiate ZookeeperBasedLockProvider" (BindException: Address already in use).
   
   Fixes:
   - Pin heartbeat tolerable misses (constant EARLY_CONFLICT_HEARTBEAT_TOLERABLE_MISSES) in buildWriteConfigForEarlyConflictDetect so the wait no longer depends on the global default, and derive the wait as interval * (misses + 1) for a clear margin.
   - Disable ZooKeeper's unused embedded admin server (zookeeper.admin.enableServer=false) to remove the fixed-port-8080 collision.
   - Move the TestingServer into a field closed in @AfterEach so a failing assertion cannot leak it across the reused fork.
   
   Closes #19068
   
   ### Describe the issue this Pull Request addresses
   
   <!-- Either describe the issue inline here with motivation behind the changes 
        (or) link to an issue by including `Closes #<issue-number>` for context. 
        If this PR includes changes to the storage format, public APIs,
        or has breaking changes, use `!` (e.g., feat!: ...) -->
   
   ### Summary and Changelog
   
   <!-- Short, plain-English summary of what users gain or what changed in behavior.
        Followed by a detailed log of all the changes. Highlight if any code was copied. -->
   
   ### Impact
   
   <!-- Describe any public API or user-facing feature change or any performance impact. -->
   
   ### Risk Level
   
   <!-- Accepted values: none, low, medium or high. Other than `none`, explain the risk.
        If medium or high, explain what verification was done to mitigate the risks. -->
   
   ### Documentation Update
   
   <!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
   
   - The config description must be updated if new configs are added or the default value of the configs are changed.
   - Any new feature or user-facing change requires updating the Hudi website. Please follow the 
     [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(spark): de-flake TestHoodieClientMultiWriter early-conflict detection [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19069:
URL: https://github.com/apache/hudi/pull/19069#issuecomment-4798207397

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0ff7de0a6440df54fe80cad7e036ddac68d5f40f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0ff7de0a6440df54fe80cad7e036ddac68d5f40f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0ff7de0a6440df54fe80cad7e036ddac68d5f40f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(spark): de-flake TestHoodieClientMultiWriter early-conflict detection [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19069:
URL: https://github.com/apache/hudi/pull/19069#issuecomment-4798889381

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0ff7de0a6440df54fe80cad7e036ddac68d5f40f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14925",
       "triggerID" : "0ff7de0a6440df54fe80cad7e036ddac68d5f40f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0ff7de0a6440df54fe80cad7e036ddac68d5f40f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14925) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(spark): de-flake TestHoodieClientMultiWriter early-conflict detection [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #19069:
URL: https://github.com/apache/hudi/pull/19069#issuecomment-4798242408

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0ff7de0a6440df54fe80cad7e036ddac68d5f40f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14925",
       "triggerID" : "0ff7de0a6440df54fe80cad7e036ddac68d5f40f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0ff7de0a6440df54fe80cad7e036ddac68d5f40f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14925) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test(spark): de-flake TestHoodieClientMultiWriter early-conflict detection [hudi]

Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous merged PR #19069:
URL: https://github.com/apache/hudi/pull/19069


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org