You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/08/12 13:46:18 UTC

[GitHub] [netbeans] sdedic opened a new pull request #3105: NETBEANS-5906: treat custom actions as enabled

sdedic opened a new pull request #3105:
URL: https://github.com/apache/netbeans/pull/3105


   See [NETBEANS-5906](https://issues.apache.org/jira/browse/NETBEANS-5906). The main issue was that **enabled** is defined by **GradleActionProviders**, but the Navigator creates its own custom action (that do not belong to any proivider, naturally). 
   Similarly user-defined custom actions are not managed by any provider. So this omission is likely to break any user-defined custom actions, too: Since they are reported as disabled, they won't be processed.
   
   During implementation I've discovered [NETBEANS-5918](https://issues.apache.org/jira/browse/NETBEANS-5918): funny issue caused by a weak listener that is not referenced from anywhere and is GCed. So the cache does not react properly when a **gradle.properties** or a action mapping XML files are created in the project dir.
   
   Finally [NETBEANS-5919](https://issues.apache.org/jira/browse/NETBEANS-5919) - it's an inconsistency, since Maven project support reports custom actions as supported...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] chrismaster commented on pull request #3105: NETBEANS-5906: treat custom actions as enabled

Posted by GitBox <gi...@apache.org>.
chrismaster commented on pull request #3105:
URL: https://github.com/apache/netbeans/pull/3105#issuecomment-903303666


   With PR#3105 run task from Navigator executes the task.
   From Projects a right click on the project name with the Gradle icon [Run Gradle] -> [Tasks] has no action.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi merged pull request #3105: NETBEANS-5906: treat custom actions as enabled

Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #3105:
URL: https://github.com/apache/netbeans/pull/3105


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] sdedic commented on pull request #3105: NETBEANS-5906: treat custom actions as enabled

Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3105:
URL: https://github.com/apache/netbeans/pull/3105#issuecomment-897661421


   @neilcsmith-net Thanks. Rebased.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] neilcsmith-net commented on pull request #3105: NETBEANS-5906: treat custom actions as enabled

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3105:
URL: https://github.com/apache/netbeans/pull/3105#issuecomment-897656503


   Thanks for looking into root cause of this.  Base branch should be `delivery`?!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi commented on pull request #3105: NETBEANS-5906: treat custom actions as enabled

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #3105:
URL: https://github.com/apache/netbeans/pull/3105#issuecomment-903319531


   Actually I'm working on the same issue. It seems the truth is somewhere in a combined solution, so I merge this one now and rebase my work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists