[jira] [Resolved] (FLINK-14926) Make sure no resource leak of RocksObject

["Yu Li (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-14926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yu Li resolved FLINK-14926.
---------------------------
    Fix Version/s: 1.10.0
       Resolution: Fixed

Fixed in master via:
 * e05618b427
 * 0602ccf1d2
 * 93deb1a709
 * 31dd8c3624
 * 2405111bd6
 * 07f08fb19a

Fixed in 1.10.0 via:
 * 13c577f6d2
 * 5326730225
 * 386dad8705
 * f5fa21b7d0
 * 6f777d5a51
 * e94bf2fe70

(Thanks [~sewen] for reviewing and merging the PR)

> Make sure no resource leak of RocksObject
> -----------------------------------------
>
>                 Key: FLINK-14926
>                 URL: https://issues.apache.org/jira/browse/FLINK-14926
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / State Backends
>    Affects Versions: 1.6.4, 1.7.2, 1.8.2, 1.9.1
>            Reporter: Yu Li
>            Assignee: Yu Li
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.10.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> When investigating FLINK-14484 to allow setting {{WriteBufferManager}} via options, we find it necessary to supply a {{close}} method in {{OptionsFactory}} to make sure resources configured in options like {{WriteBufferManager}} could/would be released.
> What's more, we're having potential risk of resource leak in {{PredefinedOptions}} such as the created [BloomFilter instance|https://github.com/apache/flink/blob/e14bd50fed42e89674ba9d01a231d5c5e59f490c/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java#L155] is never closed (regression caused by FLINK-7220 changes), and we should also fix this and add a {{close}} method in {{PredefinedOptions}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)