You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ryan McKinley (Created) (JIRA)" <ji...@apache.org> on 2012/02/21 19:43:46 UTC
[jira] [Created] (SOLR-3151) Replace zookeeper.jsp with a servlet
Replace zookeeper.jsp with a servlet
------------------------------------
Key: SOLR-3151
URL: https://issues.apache.org/jira/browse/SOLR-3151
Project: Solr
Issue Type: Improvement
Reporter: Ryan McKinley
Fix For: 4.0
The zookeeper info is currently generated with a jsp file -- making it harder to maintain then it should be, and harder to include in other applications
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3151) Replace zookeeper.jsp with a servlet
Posted by "Stefan Matheis (steffkes) (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213495#comment-13213495 ]
Stefan Matheis (steffkes) commented on SOLR-3151:
-------------------------------------------------
Just a quick note. Depending on which file you select, the current zookeeper.jsp renders invalid json. That will of course not work for the Javascript-Part, we can of course display a message in that case, but i guess it should be possible to ensure that we return valid json?
> Replace zookeeper.jsp with a servlet
> ------------------------------------
>
> Key: SOLR-3151
> URL: https://issues.apache.org/jira/browse/SOLR-3151
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
> Attachments: SOLR-3151-zookeeper-servlet.patch
>
>
> The zookeeper info is currently generated with a jsp file -- making it harder to maintain then it should be, and harder to include in other applications
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3151) Replace zookeeper.jsp with a servlet
Posted by "Erik Hatcher (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213568#comment-13213568 ]
Erik Hatcher commented on SOLR-3151:
------------------------------------
Ok, so definitely not appropriate for this to be a request handler. And yeah, that core admin is crazy stuff - wouldn't allow for a custom (or non-default, thus not Velocity) response writing. Carry on...
> Replace zookeeper.jsp with a servlet
> ------------------------------------
>
> Key: SOLR-3151
> URL: https://issues.apache.org/jira/browse/SOLR-3151
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
> Attachments: SOLR-3151-invalid-json-for-solrconfig.json, SOLR-3151-zookeeper-servlet.patch
>
>
> The zookeeper info is currently generated with a jsp file -- making it harder to maintain then it should be, and harder to include in other applications
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3151) Replace zookeeper.jsp with a servlet
Posted by "Ryan McKinley (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley resolved SOLR-3151.
---------------------------------
Resolution: Fixed
This is now a servlet, and future improvements can be tracked in SOLR-3155
> Replace zookeeper.jsp with a servlet
> ------------------------------------
>
> Key: SOLR-3151
> URL: https://issues.apache.org/jira/browse/SOLR-3151
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
> Attachments: SOLR-3151-invalid-json-for-solrconfig.json, SOLR-3151-zookeeper-servlet.patch
>
>
> The zookeeper info is currently generated with a jsp file -- making it harder to maintain then it should be, and harder to include in other applications
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3151) Replace zookeeper.jsp with a servlet
Posted by "Ryan McKinley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213092#comment-13213092 ]
Ryan McKinley commented on SOLR-3151:
-------------------------------------
The zookeeper stuff is not core-specific, it is at the top level just like CoreAdminHandler. I just copied the code from the jsp and have not really investigated -- it only uses the core to get the ZkController: core.getCoreDescriptor().getCoreContainer().getZkController();
I'm fine with it as a RequestHandler, but this would require *more* crazy logic in SolrDispatchFilter like we have with CoreAdminHandler.
any thoughts? I don't use the ZK stuff (yet) so i don't have any opinion, but we need to fix some issues with this to get the new admin UI up-to-snuff
> Replace zookeeper.jsp with a servlet
> ------------------------------------
>
> Key: SOLR-3151
> URL: https://issues.apache.org/jira/browse/SOLR-3151
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
> Attachments: SOLR-3151-zookeeper-servlet.patch
>
>
> The zookeeper info is currently generated with a jsp file -- making it harder to maintain then it should be, and harder to include in other applications
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3151) Replace zookeeper.jsp with a servlet
Posted by "Ryan McKinley (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-3151:
--------------------------------
Attachment: SOLR-3151-zookeeper-servlet.patch
This moves the .jsp to a servlet.
Can someone with more zookeeper experience (and setup) make sure this is equivalent to what we currently have?
> Replace zookeeper.jsp with a servlet
> ------------------------------------
>
> Key: SOLR-3151
> URL: https://issues.apache.org/jira/browse/SOLR-3151
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
> Attachments: SOLR-3151-zookeeper-servlet.patch
>
>
> The zookeeper info is currently generated with a jsp file -- making it harder to maintain then it should be, and harder to include in other applications
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3151) Replace zookeeper.jsp with a servlet
Posted by "Stefan Matheis (steffkes) (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Matheis (steffkes) updated SOLR-3151:
--------------------------------------------
Attachment: SOLR-3151-invalid-json-for-solrconfig.json
Generated w/ SVN Revision 1245905, is not valid. I don't not all reasons why it's correct but one will be that it contains raw linebreaks, which doesn't fit the specs. more on http://jsonlint.com/
> Replace zookeeper.jsp with a servlet
> ------------------------------------
>
> Key: SOLR-3151
> URL: https://issues.apache.org/jira/browse/SOLR-3151
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
> Attachments: SOLR-3151-invalid-json-for-solrconfig.json, SOLR-3151-zookeeper-servlet.patch
>
>
> The zookeeper info is currently generated with a jsp file -- making it harder to maintain then it should be, and harder to include in other applications
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3151) Replace zookeeper.jsp with a servlet
Posted by "Erik Hatcher (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212805#comment-13212805 ]
Erik Hatcher commented on SOLR-3151:
------------------------------------
is this core-specific? I'm not familiar yet with the ZK stuff in Solr, but the servlet patch is core-specific. So that begs the question... why not make this a request handler instead of a servlet? A request handler has the benefit of allowing all usual Solr capabilities especially allowing flexible response writing (JSON, XML, Velocity, etc).
> Replace zookeeper.jsp with a servlet
> ------------------------------------
>
> Key: SOLR-3151
> URL: https://issues.apache.org/jira/browse/SOLR-3151
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
> Attachments: SOLR-3151-zookeeper-servlet.patch
>
>
> The zookeeper info is currently generated with a jsp file -- making it harder to maintain then it should be, and harder to include in other applications
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org