[GitHub] michellethomas commented on a change in pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands

[GitBox <gi...@apache.org>]

michellethomas commented on a change in pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands
URL: https://github.com/apache/incubator-superset/pull/5032#discussion_r189660170
 
 

 ##########
 File path: superset/assets/src/explore/components/AdhocFilterEditPopover.jsx
 ##########
 @@ -78,6 +79,13 @@ export default class AdhocFilterEditPopover extends React.Component {
     document.removeEventListener('mousemove', this.onMouseMove);
   }
 
+  adjustHeight(heightDifference) {
+    this.setState(state => ({
+      ...state,
 
 Review comment:
   Do you need this? I thought you could just return the update to state.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org