[jira] [Commented] (LUCENE-6354) Add minChildren and maxChildren options to ToParentBlockJoinQuery

["Martijn van Groningen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355324#comment-14355324 ] 

Martijn van Groningen commented on LUCENE-6354:
-----------------------------------------------

I think just adding the check in TwoPhaseIterator doesn't work? The TwoPhaseIterator and the scorer need to be in sync. Also if just the ToParentBlockJoinQuery is used in a search then the TwoPhaseIterator isn't used. So I think the check does need to be in the nextDoc() method.

I do think it makes sense the let ToParentBlockJoinQuery implement asTwoPhaseIterator(), since that this query get faster. Maybe the TwoPhaseIterator being returned, can be based on the parentBits? Maybe this should be done in a different issue?

> Add minChildren and maxChildren options to ToParentBlockJoinQuery
> -----------------------------------------------------------------
>
>                 Key: LUCENE-6354
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6354
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-6354.patch, LUCENE-6354.patch
>
>
> This effectively allows to ignore parent documents with too few children documents via the minChildren option or too many matching children documents via the maxChildren option. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org