[GitHub] cordova-lib pull request #555: CB-12786: Improve logic for searching plugin ...

[stevengill <gi...@git.apache.org>]

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/555#discussion_r119950730
  
    --- Diff: cordova-fetch/index.js ---
    @@ -148,9 +148,15 @@ function trimID(target) {
             target = parts[1];
         }
     
    -    //If local path exists, set target to final directory
    +    // If local path exists, try to get plugin id from package.json or set target to final directory
         if (fs.existsSync(target)) {
    -        target = path.basename(target);
    +        var pluginId, pkgJsonPath = path.join(target, 'package.json');
    +
    +        if (fs.existsSync(pkgJsonPath)) {
    +            pluginId = JSON.parse(fs.readFileSync(pkgJsonPath)).cordova.id;
    --- End diff --
    
    why use `pkgJsonPath.cordova.id` instead of `pkgJsonPath.cordova.name` ? I don't even remember why we have `cordova.id` anymore haha. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org