[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

["jolshan (via GitHub)" <gi...@apache.org>]

jolshan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1218431394


##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -977,18 +1058,20 @@ void handleCoordinatorReady() {
                 initProducerIdVersion.maxVersion() >= 3;
     }
 
-    private void transitionTo(State target) {

Review Comment:
   Was it not possible to have a helper with just the target and CallingThread? Seeing all the nulls as parameters was a little confusing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org