You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Eric Hanson <eh...@microsoft.com> on 2013/11/19 02:31:10 UTC
Review Request 15663: Hive should be able to skip header and footer rows
when reading data file for a table
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15663/
-----------------------------------------------------------
Review request for hive and Thejas Nair.
Repository: hive-git
Description
-------
Hive should be able to skip header and footer rows when reading data file for a table
(I am uploading this on behalf of Shuaishuai Nie since he's not in the office)
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 32ab3d8
data/files/header_footer_table_1/0001.txt PRE-CREATION
data/files/header_footer_table_1/0002.txt PRE-CREATION
data/files/header_footer_table_1/0003.txt PRE-CREATION
data/files/header_footer_table_2/2012/01/01/0001.txt PRE-CREATION
data/files/header_footer_table_2/2012/01/02/0002.txt PRE-CREATION
data/files/header_footer_table_2/2012/01/03/0003.txt PRE-CREATION
itests/qtest/pom.xml a453d8a
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 5abcfc1
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java dd5cb6b
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 0ec6e63
ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java 85dd975
ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java 0686d9b
ql/src/test/queries/clientpositive/file_with_header_footer.q PRE-CREATION
ql/src/test/results/clientpositive/file_with_header_footer.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/15663/diff/
Testing
-------
Thanks,
Eric Hanson
Re: Review Request 15663: Hive should be able to skip header and footer rows
when reading data file for a table
Posted by Eric Hanson <eh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15663/#review29093
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15663/#comment56220>
What does this mean exactly? Is this lines of footer or actual total number of footers?
If it is number of footers, should say
"max number of footers ..."
itests/qtest/pom.xml
<https://reviews.apache.org/r/15663/#comment56221>
is this really supposed to be in the patch?
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment56228>
Please put a paragraph of explanation of the header/footer skipping feature right in the code. Including what it is and how to use it.
Also, please create web documentation for the new feature. Check with Lefty L. about where to put it. You could start by putting a first draft under https://cwiki.apache.org/confluence/display/Hive/DesignDocs. You could delete the design doc from there once the design becomes part of the Hive documentation.
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment56222>
Hive coding style guidelines say to put a blank line before all comments. Please check all your comments for this.
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment56227>
I recommend using "skip.header.line.count" instead of "skip.header.number" to make it explicit that you are skipping lines.
Also, use "skip.footer.line.count" instead of skip.footer.number.
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment56223>
put blank after // before first word
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java
<https://reviews.apache.org/r/15663/#comment56225>
Please put a comment before the is class explaining what it is for.
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java
<https://reviews.apache.org/r/15663/#comment56224>
use camel case (footerCur)
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java
<https://reviews.apache.org/r/15663/#comment56226>
Please run checkstyle. E.g. there should be a blank between ){
- Eric Hanson
On Nov. 19, 2013, 1:31 a.m., Eric Hanson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15663/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 1:31 a.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5795
> https://issues.apache.org/jira/browse/HIVE-5795
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Hive should be able to skip header and footer rows when reading data file for a table
>
> (I am uploading this on behalf of Shuaishuai Nie since he's not in the office)
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 32ab3d8
> data/files/header_footer_table_1/0001.txt PRE-CREATION
> data/files/header_footer_table_1/0002.txt PRE-CREATION
> data/files/header_footer_table_1/0003.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/01/0001.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/02/0002.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/03/0003.txt PRE-CREATION
> itests/qtest/pom.xml a453d8a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 5abcfc1
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java dd5cb6b
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 0ec6e63
> ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java 85dd975
> ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java 0686d9b
> ql/src/test/queries/clientpositive/file_with_header_footer.q PRE-CREATION
> ql/src/test/results/clientpositive/file_with_header_footer.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15663/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric Hanson
>
>
Re: Review Request 15663: Hive should be able to skip header and footer rows
when reading data file for a table
Posted by Shuaishuai Nie <sh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15663/#review30270
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15663/#comment57957>
Hi Eric, I uploaded the new diff with the fixes here https://reviews.apache.org/r/16184/diff/#index_header
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15663/#comment57958>
Hi Thejas, I uploaded the new diff file with the fixes in the review board here: https://reviews.apache.org/r/16184/diff/#index_header
- Shuaishuai Nie
On Nov. 19, 2013, 1:31 a.m., Eric Hanson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15663/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 1:31 a.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5795
> https://issues.apache.org/jira/browse/HIVE-5795
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Hive should be able to skip header and footer rows when reading data file for a table
>
> (I am uploading this on behalf of Shuaishuai Nie since he's not in the office)
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 32ab3d8
> data/files/header_footer_table_1/0001.txt PRE-CREATION
> data/files/header_footer_table_1/0002.txt PRE-CREATION
> data/files/header_footer_table_1/0003.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/01/0001.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/02/0002.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/03/0003.txt PRE-CREATION
> itests/qtest/pom.xml a453d8a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 5abcfc1
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java dd5cb6b
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 0ec6e63
> ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java 85dd975
> ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java 0686d9b
> ql/src/test/queries/clientpositive/file_with_header_footer.q PRE-CREATION
> ql/src/test/results/clientpositive/file_with_header_footer.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15663/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric Hanson
>
>
Re: Review Request 15663: Hive should be able to skip header and footer rows
when reading data file for a table
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15663/#review29097
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15663/#comment56238>
config params also need to be added to hive-default.xml.template
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment56239>
this code should be refactored to be re-used in both places.
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java
<https://reviews.apache.org/r/15663/#comment56232>
I think it is better to fail the query if it is not a number. Otherwise, user will silently get data different from what is expected.
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java
<https://reviews.apache.org/r/15663/#comment56233>
need to update comment.
same comment regarding exception handling as for header.
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
<https://reviews.apache.org/r/15663/#comment56230>
should this conf param go into HiveConf ?
- Thejas Nair
On Nov. 19, 2013, 1:31 a.m., Eric Hanson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15663/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 1:31 a.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5795
> https://issues.apache.org/jira/browse/HIVE-5795
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Hive should be able to skip header and footer rows when reading data file for a table
>
> (I am uploading this on behalf of Shuaishuai Nie since he's not in the office)
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 32ab3d8
> data/files/header_footer_table_1/0001.txt PRE-CREATION
> data/files/header_footer_table_1/0002.txt PRE-CREATION
> data/files/header_footer_table_1/0003.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/01/0001.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/02/0002.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/03/0003.txt PRE-CREATION
> itests/qtest/pom.xml a453d8a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 5abcfc1
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java dd5cb6b
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 0ec6e63
> ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java 85dd975
> ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java 0686d9b
> ql/src/test/queries/clientpositive/file_with_header_footer.q PRE-CREATION
> ql/src/test/results/clientpositive/file_with_header_footer.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15663/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric Hanson
>
>
Re: Review Request 15663: Hive should be able to skip header and footer rows
when reading data file for a table
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15663/#review29253
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment56427>
I think this code to separate header reading and initializing footer buffer a separate function to improve readability.
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment56424>
can you make this a constant string and referce the constant variable name ?
Unfortunately (for some historic reason that I don't understand) the place where all the similar constants are being stored is in serde/if/serde.thrift
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment56425>
I think it is better fail here and let the user know, rather than use a smaller footer skip lines than what user specified.
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java
<https://reviews.apache.org/r/15663/#comment56426>
how about using hive's ObjectPair instead ?
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
<https://reviews.apache.org/r/15663/#comment56401>
Sorry, I had failed to notice that this is a table property. But we need to document this table property.
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
<https://reviews.apache.org/r/15663/#comment56404>
This does not handle the case where multiple splits are combined together.
We need to disable combination of splits in CombineHiveInputFormat getSplits() call.
ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java
<https://reviews.apache.org/r/15663/#comment56422>
Is this change for avoiding some NPE ?
ql/src/test/queries/clientpositive/file_with_header_footer.q
<https://reviews.apache.org/r/15663/#comment56423>
can you add some negative tests where skip.footer.number exceeds hive.file.max.footer ?
- Thejas Nair
On Nov. 19, 2013, 1:31 a.m., Eric Hanson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15663/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 1:31 a.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5795
> https://issues.apache.org/jira/browse/HIVE-5795
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Hive should be able to skip header and footer rows when reading data file for a table
>
> (I am uploading this on behalf of Shuaishuai Nie since he's not in the office)
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 32ab3d8
> data/files/header_footer_table_1/0001.txt PRE-CREATION
> data/files/header_footer_table_1/0002.txt PRE-CREATION
> data/files/header_footer_table_1/0003.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/01/0001.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/02/0002.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/03/0003.txt PRE-CREATION
> itests/qtest/pom.xml a453d8a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 5abcfc1
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java dd5cb6b
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 0ec6e63
> ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java 85dd975
> ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java 0686d9b
> ql/src/test/queries/clientpositive/file_with_header_footer.q PRE-CREATION
> ql/src/test/results/clientpositive/file_with_header_footer.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15663/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric Hanson
>
>
Re: Review Request 15663: Hive should be able to skip header and footer rows
when reading data file for a table
Posted by Shuaishuai Nie <sh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15663/#review30269
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15663/#comment57938>
this is the maximum number of footer a user can define. This prevent user defines too many footers which consume memory
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/15663/#comment57939>
fixed
itests/qtest/pom.xml
<https://reviews.apache.org/r/15663/#comment57940>
this is necessary if the test is in the MimimrCliDriver test class
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment57941>
comment added
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment57942>
Hi Eric, do you mean I need a blank line before each comment? I didn't see this on other part of the code. Or you mean a space after "//"?
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment57943>
fixed
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment57944>
name changed
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment57945>
Since the return behavior is different in both place, it is hard to reuse the code in both place because of the minor differences
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment57946>
fixed
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment57947>
fixed
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java
<https://reviews.apache.org/r/15663/#comment57948>
fixed
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java
<https://reviews.apache.org/r/15663/#comment57949>
fixed the comment. Since I need deep copy of the key and value field through ReflectionUtils, this new class is necessary
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java
<https://reviews.apache.org/r/15663/#comment57950>
fixed
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java
<https://reviews.apache.org/r/15663/#comment57951>
fixed
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java
<https://reviews.apache.org/r/15663/#comment57952>
fixed
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java
<https://reviews.apache.org/r/15663/#comment57953>
fixed
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
<https://reviews.apache.org/r/15663/#comment57954>
since the header and footer is removed based on each file, I think it should be fine if multiple splits are combined since each file will have its own path
ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java
<https://reviews.apache.org/r/15663/#comment57955>
yes, otherwise an exception will be thrown when accessing pathToPartitionInfo info during the test since the job context is incomplete in the unit test
ql/src/test/queries/clientpositive/file_with_header_footer.q
<https://reviews.apache.org/r/15663/#comment57956>
negative tests added for this senario
- Shuaishuai Nie
On Nov. 19, 2013, 1:31 a.m., Eric Hanson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15663/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 1:31 a.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5795
> https://issues.apache.org/jira/browse/HIVE-5795
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Hive should be able to skip header and footer rows when reading data file for a table
>
> (I am uploading this on behalf of Shuaishuai Nie since he's not in the office)
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 32ab3d8
> data/files/header_footer_table_1/0001.txt PRE-CREATION
> data/files/header_footer_table_1/0002.txt PRE-CREATION
> data/files/header_footer_table_1/0003.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/01/0001.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/02/0002.txt PRE-CREATION
> data/files/header_footer_table_2/2012/01/03/0003.txt PRE-CREATION
> itests/qtest/pom.xml a453d8a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 5abcfc1
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java dd5cb6b
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 0ec6e63
> ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java 85dd975
> ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java 0686d9b
> ql/src/test/queries/clientpositive/file_with_header_footer.q PRE-CREATION
> ql/src/test/results/clientpositive/file_with_header_footer.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15663/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric Hanson
>
>
Re: Review Request 15663: Hive should be able to skip header and footer rows
when reading data file for a table
Posted by Eric Hanson <eh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15663/
-----------------------------------------------------------
(Updated Nov. 19, 2013, 1:31 a.m.)
Review request for hive and Thejas Nair.
Bugs: HIVE-5795
https://issues.apache.org/jira/browse/HIVE-5795
Repository: hive-git
Description
-------
Hive should be able to skip header and footer rows when reading data file for a table
(I am uploading this on behalf of Shuaishuai Nie since he's not in the office)
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 32ab3d8
data/files/header_footer_table_1/0001.txt PRE-CREATION
data/files/header_footer_table_1/0002.txt PRE-CREATION
data/files/header_footer_table_1/0003.txt PRE-CREATION
data/files/header_footer_table_2/2012/01/01/0001.txt PRE-CREATION
data/files/header_footer_table_2/2012/01/02/0002.txt PRE-CREATION
data/files/header_footer_table_2/2012/01/03/0003.txt PRE-CREATION
itests/qtest/pom.xml a453d8a
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 5abcfc1
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java dd5cb6b
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 0ec6e63
ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java 85dd975
ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java 0686d9b
ql/src/test/queries/clientpositive/file_with_header_footer.q PRE-CREATION
ql/src/test/results/clientpositive/file_with_header_footer.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/15663/diff/
Testing
-------
Thanks,
Eric Hanson