[jira] Commented: (HTTPCORE-37) Spring integration for HttpParams

["Roland Weber (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTTPCORE-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469134 ] 

Roland Weber commented on HTTPCORE-37:
--------------------------------------

Hi Stojce,

this code needs some polishing. The missing JavaDocs are a minor problem since it'll go to the contrib package anyway. I'd probably have to dig into Spring to understand what the "singleton" flag is supposed to do. The major problem is that you are determining the type of the parameter based on the value. If that has worked for you so far, that's only because you haven't used it extensively. If a parameter is defined to be of type Long, it has to be a Long even if the value happens to fit into an Integer. Otherwise, there will be a ClassCastException when the parameter is accessed. Have a look at o.a.h.i.DefaultHttpParams#getLongParameter to see what I mean.

cheers,
  Roland


> Spring integration for HttpParams
> ---------------------------------
>
>                 Key: HTTPCORE-37
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-37
>             Project: HttpComponents Core
>          Issue Type: Improvement
>          Components: HttpCore Spring
>         Environment: Spring 2.0
>            Reporter: Stojce Dimski
>             Fix For: 4.0-alpha4
>
>         Attachments: springHttpParams.zip
>
>
> I quickly prototyped a simple spring integration trough HttpParamsFactoryBean which load parameters from external .properties file and decodes them into HttpParams.
> Approach at solving this issue is pretty 'pragmatic' as would tell Roland, but works like charm for me ;-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org