[GitHub] [iceberg] singhpk234 commented on a change in pull request #3984: Spark 3.2: Implement merge-on-read UPDATE

[GitBox <gi...@apache.org>]

singhpk234 commented on a change in pull request #3984:
URL: https://github.com/apache/iceberg/pull/3984#discussion_r799329980



##########
File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkDistributionAndOrderingUtil.java
##########
@@ -146,14 +146,14 @@ private static Distribution buildCopyOnWriteDeleteUpdateDistribution(Table table
 
   public static Distribution buildPositionDeltaDistribution(Table table, Command command,
                                                             DistributionMode distributionMode) {
-    if (command == DELETE) {
-      return positionDeleteDistribution(distributionMode);
+    if (command == DELETE || command == UPDATE) {
+      return buildPositionDeleteUpdateDistribution(distributionMode);
     } else {
       throw new IllegalArgumentException("Only position deletes are currently supported");

Review comment:
       [minor] can update the exception message here as well, to include `update` command: 
   
   ```suggestion
         throw new IllegalArgumentException("Only position deletes and updates are currently supported");
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org