[commons-rng] branch master updated: Do not leak package-private class in public API

[ah...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git


The following commit(s) were added to refs/heads/master by this push:
     new 22bba877 Do not leak package-private class in public API
22bba877 is described below

commit 22bba87751be8a6fe9b460fef4b5ad7a970ebee5
Author: aherbert <ah...@apache.org>
AuthorDate: Mon May 9 13:55:12 2022 +0100

    Do not leak package-private class in public API
    
    Reduces the 'protected' copy method to 'package-private'.
    
    This issue was detected using the revapi maven plugin.
---
 .../main/java/org/apache/commons/rng/core/source64/AbstractL128.java    | 2 +-
 .../src/main/java/org/apache/commons/rng/core/source64/AbstractL64.java | 2 +-
 .../main/java/org/apache/commons/rng/core/source64/L128X1024Mix.java    | 2 +-
 .../src/main/java/org/apache/commons/rng/core/source64/L128X128Mix.java | 2 +-
 .../src/main/java/org/apache/commons/rng/core/source64/L128X256Mix.java | 2 +-
 .../src/main/java/org/apache/commons/rng/core/source64/L64X1024Mix.java | 2 +-
 .../src/main/java/org/apache/commons/rng/core/source64/L64X256Mix.java  | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/AbstractL128.java b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/AbstractL128.java
index 9617f1d0..47ca144b 100644
--- a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/AbstractL128.java
+++ b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/AbstractL128.java
@@ -181,5 +181,5 @@ abstract class AbstractL128 extends LongProvider implements LongJumpableUniformR
      *
      * @return the copy
      */
-    protected abstract AbstractL128 copy();
+    abstract AbstractL128 copy();
 }
diff --git a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/AbstractL64.java b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/AbstractL64.java
index 4509a6d6..dabaf64e 100644
--- a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/AbstractL64.java
+++ b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/AbstractL64.java
@@ -146,5 +146,5 @@ abstract class AbstractL64 extends LongProvider implements LongJumpableUniformRa
      *
      * @return the copy
      */
-    protected abstract AbstractL64 copy();
+    abstract AbstractL64 copy();
 }
diff --git a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L128X1024Mix.java b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L128X1024Mix.java
index 4728114b..0417026c 100644
--- a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L128X1024Mix.java
+++ b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L128X1024Mix.java
@@ -180,7 +180,7 @@ public class L128X1024Mix extends AbstractL128 {
 
     /** {@inheritDoc} */
     @Override
-    protected AbstractL128 copy() {
+    AbstractL128 copy() {
         // This exists to ensure the jump function performed in the super class returns
         // the correct class type. It should not be public.
         return new L128X1024Mix(this);
diff --git a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L128X128Mix.java b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L128X128Mix.java
index e5a0c359..8d905f24 100644
--- a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L128X128Mix.java
+++ b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L128X128Mix.java
@@ -197,7 +197,7 @@ public class L128X128Mix extends AbstractL128 {
 
     /** {@inheritDoc} */
     @Override
-    protected AbstractL128 copy() {
+    AbstractL128 copy() {
         // This exists to ensure the jump function performed in the super class returns
         // the correct class type. It should not be public.
         return new L128X128Mix(this);
diff --git a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L128X256Mix.java b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L128X256Mix.java
index 26e78d7d..16a1b0a3 100644
--- a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L128X256Mix.java
+++ b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L128X256Mix.java
@@ -225,7 +225,7 @@ public class L128X256Mix extends AbstractL128 {
 
     /** {@inheritDoc} */
     @Override
-    protected AbstractL128 copy() {
+    AbstractL128 copy() {
         // This exists to ensure the jump function performed in the super class returns
         // the correct class type. It should not be public.
         return new L128X256Mix(this);
diff --git a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L64X1024Mix.java b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L64X1024Mix.java
index 6fa62b8b..d78b0f80 100644
--- a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L64X1024Mix.java
+++ b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L64X1024Mix.java
@@ -171,7 +171,7 @@ public class L64X1024Mix extends AbstractL64 {
 
     /** {@inheritDoc} */
     @Override
-    protected AbstractL64 copy() {
+    AbstractL64 copy() {
         // This exists to ensure the jump function performed in the super class returns
         // the correct class type. It should not be public.
         return new L64X1024Mix(this);
diff --git a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L64X256Mix.java b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L64X256Mix.java
index eeb74862..61ad84d2 100644
--- a/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L64X256Mix.java
+++ b/commons-rng-core/src/main/java/org/apache/commons/rng/core/source64/L64X256Mix.java
@@ -214,7 +214,7 @@ public class L64X256Mix extends AbstractL64 {
 
     /** {@inheritDoc} */
     @Override
-    protected AbstractL64 copy() {
+    AbstractL64 copy() {
         // This exists to ensure the jump function performed in the super class returns
         // the correct class type. It should not be public.
         return new L64X256Mix(this);