You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/11/10 10:05:42 UTC
[GitHub] [avro] martin-g opened a new pull request #1395: AVRO-3251 AVDL files containing fields called "uuid" no longer compile.
martin-g opened a new pull request #1395:
URL: https://github.com/apache/avro/pull/1395
### Jira
- [X] My PR addresses the following [AVRO-3251](https://issues.apache.org/jira/browse/AVRO-3251) issue
### Tests
- [X] My PR updates the unit tests
### Commits
- [X] My commits all reference Jira issues in their subject lines.
### Documentation
- [X] No new functionality. Only bug fixes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] opwvhk commented on a change in pull request #1395: AVRO-3251 AVDL files containing fields called "uuid" no longer compile.
Posted by GitBox <gi...@apache.org>.
opwvhk commented on a change in pull request #1395:
URL: https://github.com/apache/avro/pull/1395#discussion_r753298779
##########
File path: lang/java/compiler/src/test/idl/input/reservedwords.avdl
##########
@@ -19,4 +19,9 @@
protocol Foo {
void `error`();
void `void`();
+ void `idl`();
+ void `import`();
+ void `oneway`();
+ void `null`();
+ void `local_timestamp_ms`();
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] opwvhk commented on pull request #1395: AVRO-3251 AVDL files containing fields called "uuid" no longer compile.
Posted by GitBox <gi...@apache.org>.
opwvhk commented on pull request #1395:
URL: https://github.com/apache/avro/pull/1395#issuecomment-970291570
Looks good, but incomplete.
There are 31 keywords in the IDL grammar, and only 25 of them are accepted as identifier.
Fields named `idl`, `import`, `oneway`, `null`, `local_timestamp_ms` or `uuid` are all ignored. This commit only fixes the last one.
To verify, see lines 235-264, and lines 1582-1607.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1395: AVRO-3251 AVDL files containing fields called "uuid" no longer compile.
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1395:
URL: https://github.com/apache/avro/pull/1395#issuecomment-970615990
Thanks for the review!
> Fields named `idl`, `import`, `oneway`, `null`, `local_timestamp_ms` or `uuid` are all ignored.
Are you sure about `local_timestamp_ms` ?
It is at https://github.com/apache/avro/blob/99547e0ee2e0a4a839253848d7b34bac7f5e4cea/lang/java/compiler/src/main/javacc/org/apache/avro/compiler/idl/idl.jj#L263 and https://github.com/apache/avro/blob/99547e0ee2e0a4a839253848d7b34bac7f5e4cea/lang/java/compiler/src/main/javacc/org/apache/avro/compiler/idl/idl.jj#L1605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] opwvhk commented on pull request #1395: AVRO-3251 AVDL files containing fields called "uuid" no longer compile.
Posted by GitBox <gi...@apache.org>.
opwvhk commented on pull request #1395:
URL: https://github.com/apache/avro/pull/1395#issuecomment-971260246
Absolutely right Martin! I've done the comparison again, but now with sort&diff instead of by hand... there were only 5 omissions (including uuid), instead of 6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #1395: AVRO-3251 AVDL files containing fields called "uuid" no longer compile.
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #1395:
URL: https://github.com/apache/avro/pull/1395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org