You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2024/08/01 11:34:11 UTC
[PR] GH-43507: [C++] Use ViewOrCopyTo instead of CopyTo when pretty printing non-CPU data [arrow]
jorisvandenbossche opened a new pull request, #43508:
URL: https://github.com/apache/arrow/pull/43508
### Rationale for this change
When ensuring the data we are pretty-printing is on the CPU, we can use `ViewOrCopyTo` instead of `CopyTo`, in case the data can be viewed as CPU data without a copy.
### Are these changes tested?
Yes (I added a test that uses CUDA host memory, which should be a case where it can be viewed and doesn't need to be copied, but of course the test it not actually ensuring we avoid the copy, just that the printing works)
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43507: [C++] Use ViewOrCopyTo instead of CopyTo when pretty printing non-CPU data [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #43508:
URL: https://github.com/apache/arrow/pull/43508#issuecomment-2264922879
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b35e7ddbefe394ab7e5a6b1c3f3bb476cdc800f2.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/28257558839) has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43507: [C++] Use ViewOrCopyTo instead of CopyTo when pretty printing non-CPU data [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #43508:
URL: https://github.com/apache/arrow/pull/43508#issuecomment-2262842416
@github-actions crossbow submit test-cuda-cpp test-cuda-python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43507: [C++] Use ViewOrCopyTo instead of CopyTo when pretty printing non-CPU data [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #43508:
URL: https://github.com/apache/arrow/pull/43508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43507: [C++] Use ViewOrCopyTo instead of CopyTo when pretty printing non-CPU data [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43508:
URL: https://github.com/apache/arrow/pull/43508#issuecomment-2262846837
Revision: 1760a86941c885a3a06796c2b16083bd0b1020de
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ac5d396a7c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ac5d396a7c)
|Task|Status|
|----|------|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/10197724913/job/28211158616)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/10197725205/job/28211159353)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org