[GitHub] [inlong] vernedeng commented on a diff in pull request #8463: [INLONG-8442][Manager]Manager support delete tenant and delete tenant role

["vernedeng (via GitHub)" <gi...@apache.org>]

vernedeng commented on code in PR #8463:
URL: https://github.com/apache/inlong/pull/8463#discussion_r1255320759


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/user/TenantRoleServiceImpl.java:
##########
@@ -116,4 +116,9 @@ public TenantRoleInfo getByUsernameAndTenant(String name, String tenant) {
         return CommonBeanUtils.copyProperties(entity, TenantRoleInfo::new);
     }
 
+    @Override
+    public boolean delete(Integer id) {
+        return tenantUserRoleEntityMapper.deleteById(id) > 0;

Review Comment:
   No need to check if the delete result bigger than 0, just return it directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org