You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ant.apache.org by bu...@apache.org on 2006/04/29 16:27:23 UTC

DO NOT REPLY [Bug 38973] - Expand.jar protected void extractFile is coded wrong.

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38973>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38973


bodewig@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dev@ant.apache.org
         AssignedTo|dev@ant.apache.org          |bodewig@apache.org
             Status|NEEDINFO                    |NEW




------- Additional Comments From bodewig@apache.org  2006-04-29 14:27 -------
I think Vijay is correct with his first change, but wrong on the second.

Currently the code would only extract files that are matched by all patternsets
instead of at least one (that's what all the other tasks do) - this is the first
change.

In the second loop we do want to check against all patterns as long as the entry
doesn't match one of the excludes.

I'll add a testcase or two and change it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org