You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by KurtYoung <gi...@git.apache.org> on 2017/02/17 09:04:37 UTC
[GitHub] flink pull request #3339: [FLINK-5586] [table] Extend TableProgramsClusterTe...
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/3339
[FLINK-5586] [table] Extend TableProgramsClusterTestBase for object reuse mode
Make all cluster-based ITCases verified in object reuse mode. This only includes batch table tests now.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KurtYoung/flink flink-5586
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3339.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3339
----
commit cef47477601339d374f401439be2001d408c5014
Author: Kurt Young <yk...@gmail.com>
Date: 2017-02-17T09:02:23Z
[FLINK-5586] [table] Extend TableProgramsClusterTestBase for object reuse mode
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3339: [FLINK-5586] [table] Extend TableProgramsClusterTestBase ...
Posted by KurtYoung <gi...@git.apache.org>.
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3339
rebased to the latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3339: [FLINK-5586] [table] Extend TableProgramsClusterTestBase ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3339
I can do it as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3339: [FLINK-5586] [table] Extend TableProgramsClusterTe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3339
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3339: [FLINK-5586] [table] Extend TableProgramsClusterTestBase ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3339
The changes look good to me. Thanks @KurtYoung
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3339: [FLINK-5586] [table] Extend TableProgramsClusterTestBase ...
Posted by KurtYoung <gi...@git.apache.org>.
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3339
Seems like this will effect the new aggregate interface and make the tests failed, will wait for that fix first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3339: [FLINK-5586] [table] Extend TableProgramsClusterTestBase ...
Posted by KurtYoung <gi...@git.apache.org>.
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3339
I don't have merge permission yet, can you help merge this @twalthr ? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3339: [FLINK-5586] [table] Extend TableProgramsClusterTestBase ...
Posted by KurtYoung <gi...@git.apache.org>.
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3339
hey @fhueske can you take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3339: [FLINK-5586] [table] Extend TableProgramsClusterTestBase ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3339
Hi @KurtYoung, FLINK-5955 was resolved by #3465.
This PR should be good to merge now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---