You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by VSJTech <gi...@git.apache.org> on 2017/12/13 06:06:33 UTC
[GitHub] eagle pull request #972: EAGLE-EAGLE-1071 Login form takes empty entries
GitHub user VSJTech opened a pull request:
https://github.com/apache/eagle/pull/972
EAGLE-EAGLE-1071 Login form takes empty entries
<!--
{% comment %}
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to you under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
{% endcomment %}
-->
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[EAGLE-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/VSJTech/eagle master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/eagle/pull/972.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #972
----
commit f6fe0ce21c401fd7416bd1a2470ecb38c08066be
Author: sukanagaraj <su...@paypal.com>
Date: 2017-12-13T05:58:09Z
to check empty entries on the login form. validating the same
----
---
[GitHub] eagle pull request #972: EAGLE-EAGLE-1071 Login form takes empty entries
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/eagle/pull/972
---
[GitHub] eagle pull request #972: EAGLE-EAGLE-1071 Login form takes empty entries
Posted by zombieJ <gi...@git.apache.org>.
Github user zombieJ commented on a diff in the pull request:
https://github.com/apache/eagle/pull/972#discussion_r158444289
--- Diff: eagle-server/src/main/webapp/app/dev/public/js/ctrls/authCtrl.js ---
@@ -26,6 +26,14 @@
$scope.password = '';
$scope.login = function () {
+ if (!$scope.username || !$scope.password)
--- End diff --
Hi @VSJTech,
Look good to me. And could you help to format the code?
Thanks
---
[GitHub] eagle pull request #972: EAGLE-EAGLE-1071 Login form takes empty entries
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/972#discussion_r157673368
--- Diff: eagle-server/src/main/webapp/app/dev/public/js/ctrls/authCtrl.js ---
@@ -26,6 +26,14 @@
$scope.password = '';
$scope.login = function () {
+ if (!$scope.username || !$scope.password)
--- End diff --
@zombieJ could you please have a look about the changes?
---
[GitHub] eagle issue #972: EAGLE-EAGLE-1071 Login form takes empty entries
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on the issue:
https://github.com/apache/eagle/pull/972
pls update the PR as per the format, pls refer other closed PRs.
- update description
- add [EAGLE-*] in title
Thanks
---