You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/05/08 22:18:13 UTC
Re: Review Request 66861: Added per-framework DRF position metrics to
the allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66861/
-----------------------------------------------------------
(Updated May 8, 2018, 10:18 p.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
Repository: mesos
Description
-------
During each allocation cycle, the allocator re-sorts roles and
frameworks for each agent in the cluster. This means that for each
agent there exists a total order of (role, framework) tuples.
This patch adds per-framework, per-role metrics which track the
minimum and maximum positions attained by the framework in this
sorting process, from the most recent allocation cycle.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp 1000968be6a2935a4cac571414d7f06d7df7acf0
src/master/allocator/mesos/metrics.hpp 6d386225c301d5ab44f3cc0ecdd1478fb5162e5b
src/master/allocator/mesos/metrics.cpp 5194f5b3b3f507b36f02300775230157db3dd477
Diff: https://reviews.apache.org/r/66861/diff/2/
Changes: https://reviews.apache.org/r/66861/diff/1-2/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 66861: Added per-framework DRF position metrics to
the allocator.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66861/
-----------------------------------------------------------
(Updated July 18, 2018, 1:44 a.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Repository: mesos
Description
-------
During each allocation cycle, the allocator re-sorts roles and
frameworks for each agent in the cluster. This means that for each
agent there exists a total order of (role, framework) tuples.
This patch adds per-framework, per-role metrics which track the
minimum and maximum positions attained by the framework in this
sorting process, from the most recent allocation cycle.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b
src/master/allocator/mesos/metrics.hpp 6d386225c301d5ab44f3cc0ecdd1478fb5162e5b
src/master/allocator/mesos/metrics.cpp 82990b2dc0b827a43a392d898667eaf58c77ea36
Diff: https://reviews.apache.org/r/66861/diff/5/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 66861: Added per-framework DRF position metrics to
the allocator.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66861/
-----------------------------------------------------------
(Updated July 9, 2018, 3:46 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Repository: mesos
Description
-------
During each allocation cycle, the allocator re-sorts roles and
frameworks for each agent in the cluster. This means that for each
agent there exists a total order of (role, framework) tuples.
This patch adds per-framework, per-role metrics which track the
minimum and maximum positions attained by the framework in this
sorting process, from the most recent allocation cycle.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp 5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b
src/master/allocator/mesos/metrics.hpp 6d386225c301d5ab44f3cc0ecdd1478fb5162e5b
src/master/allocator/mesos/metrics.cpp 82990b2dc0b827a43a392d898667eaf58c77ea36
Diff: https://reviews.apache.org/r/66861/diff/5/
Changes: https://reviews.apache.org/r/66861/diff/4-5/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 66861: Added per-framework DRF position metrics to
the allocator.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66861/
-----------------------------------------------------------
(Updated July 3, 2018, 9:33 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
Repository: mesos
Description
-------
During each allocation cycle, the allocator re-sorts roles and
frameworks for each agent in the cluster. This means that for each
agent there exists a total order of (role, framework) tuples.
This patch adds per-framework, per-role metrics which track the
minimum and maximum positions attained by the framework in this
sorting process, from the most recent allocation cycle.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp 5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b
src/master/allocator/mesos/metrics.hpp 6d386225c301d5ab44f3cc0ecdd1478fb5162e5b
src/master/allocator/mesos/metrics.cpp 82990b2dc0b827a43a392d898667eaf58c77ea36
Diff: https://reviews.apache.org/r/66861/diff/4/
Changes: https://reviews.apache.org/r/66861/diff/3-4/
Testing (updated)
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 66861: Added per-framework DRF position metrics to
the allocator.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66861/
-----------------------------------------------------------
(Updated May 9, 2018, 7:32 p.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
Changes
-------
Made use of the new common helpers.
Repository: mesos
Description
-------
During each allocation cycle, the allocator re-sorts roles and
frameworks for each agent in the cluster. This means that for each
agent there exists a total order of (role, framework) tuples.
This patch adds per-framework, per-role metrics which track the
minimum and maximum positions attained by the framework in this
sorting process, from the most recent allocation cycle.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp 1000968be6a2935a4cac571414d7f06d7df7acf0
src/master/allocator/mesos/metrics.hpp 6d386225c301d5ab44f3cc0ecdd1478fb5162e5b
src/master/allocator/mesos/metrics.cpp 5194f5b3b3f507b36f02300775230157db3dd477
Diff: https://reviews.apache.org/r/66861/diff/3/
Changes: https://reviews.apache.org/r/66861/diff/2-3/
Testing
-------
Thanks,
Greg Mann