You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/23 13:19:29 UTC
[GitHub] [tvm] gromero opened a new pull request #9090: [microTVM] Add wrapper for creating project using a MLF
gromero opened a new pull request #9090:
URL: https://github.com/apache/tvm/pull/9090
Currently there is already a wrapper function for creating a new project
directory based on an ExportableModule, but there isn't one for creating
a new project directory based on an existing MLF archive, which is also
handy. Hence that commit adds a new wrapper for creating a project using
an existing model compiled and kept in a MLF archive.
Signed-off-by: Gustavo Romero <gu...@linaro.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron merged pull request #9090: [microTVM] Add wrapper for creating project using a MLF
Posted by GitBox <gi...@apache.org>.
leandron merged pull request #9090:
URL: https://github.com/apache/tvm/pull/9090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #9090: [microTVM] Add wrapper for creating project using a MLF
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #9090:
URL: https://github.com/apache/tvm/pull/9090#issuecomment-931322027
@leandron thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #9090: [microTVM] Add wrapper for creating project using a MLF
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #9090:
URL: https://github.com/apache/tvm/pull/9090#issuecomment-925810172
cc @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #9090: [microTVM] Add wrapper for creating project using a MLF
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #9090:
URL: https://github.com/apache/tvm/pull/9090#issuecomment-930236057
@areusch @Mousius Thanks for the reviews. Sorry for the respin delay. I've fixed the offending line to satisfy the linter and also fixed the type hints for the added function (s/typing.Union/Union/) I think CI haven't caught it because the code is not being used currently -- I found that when using the code on my tvmc micro work. Hopefully https://github.com/apache/tvm/pull/9090/commits/7f6da2c167c053ad11c32464c48515595d0a4bec will be all right for the CI. Cheers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #9090: [microTVM] Add wrapper for creating project using a MLF
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #9090:
URL: https://github.com/apache/tvm/pull/9090#issuecomment-926813062
@gromero thanks, please fix the CI issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero edited a comment on pull request #9090: [microTVM] Add wrapper for creating project using a MLF
Posted by GitBox <gi...@apache.org>.
gromero edited a comment on pull request #9090:
URL: https://github.com/apache/tvm/pull/9090#issuecomment-925825371
@Mousius Thanks for the review! All changes done in https://github.com/apache/tvm/pull/9090/commits/7bdd26ca5b2e2dcd69136a8107f0ccf2245a1cb3
Cheers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #9090: [microTVM] Add wrapper for creating project using a MLF
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #9090:
URL: https://github.com/apache/tvm/pull/9090#issuecomment-931258676
Thanks @gromero @Mousius and @areusch - this is merged now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #9090: [microTVM] Add wrapper for creating project using a MLF
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #9090:
URL: https://github.com/apache/tvm/pull/9090#issuecomment-925825371
@Mousius Thank for the review! All changes done in https://github.com/apache/tvm/pull/9090/commits/7bdd26ca5b2e2dcd69136a8107f0ccf2245a1cb3
Cheers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on a change in pull request #9090: [microTVM] Add wrapper for creating project using a MLF
Posted by GitBox <gi...@apache.org>.
Mousius commented on a change in pull request #9090:
URL: https://github.com/apache/tvm/pull/9090#discussion_r714794053
##########
File path: python/tvm/micro/project.py
##########
@@ -154,3 +154,36 @@ def generate_project(
"""
template = TemplateProject.from_directory(str(template_project_dir))
return template.generate_project(module, str(generated_project_dir), options)
+
+
+def generate_project_from_mlf(
+ template_project_dir: typing.Union[pathlib.Path, str],
+ project_dir: typing.Union[pathlib.Path, str],
+ mlf: typing.Union[pathlib.Path, str],
+ options: dict,
+):
+ """Generate a project from a platform template and an existing MLF.
Review comment:
```suggestion
"""Generate a project from a platform template and an existing Model Library Format (MLF) archive.
```
##########
File path: python/tvm/micro/project.py
##########
@@ -154,3 +154,36 @@ def generate_project(
"""
template = TemplateProject.from_directory(str(template_project_dir))
return template.generate_project(module, str(generated_project_dir), options)
+
+
+def generate_project_from_mlf(
+ template_project_dir: typing.Union[pathlib.Path, str],
+ project_dir: typing.Union[pathlib.Path, str],
+ mlf: typing.Union[pathlib.Path, str],
+ options: dict,
+):
+ """Generate a project from a platform template and an existing MLF.
+
+ Parameters
+ ----------
+ template_project_path : pathlib.Path or str
+ Path to a template project containing a microTVM Project API server.
+
+ project_dir : pathlib.Path or str
+ Path to a directory where the project will be created.
+
+ mlf : pathlib.Path or str
Review comment:
```suggestion
mlf_path : pathlib.Path or str
```
##########
File path: python/tvm/micro/project.py
##########
@@ -154,3 +154,36 @@ def generate_project(
"""
template = TemplateProject.from_directory(str(template_project_dir))
return template.generate_project(module, str(generated_project_dir), options)
+
+
+def generate_project_from_mlf(
+ template_project_dir: typing.Union[pathlib.Path, str],
+ project_dir: typing.Union[pathlib.Path, str],
+ mlf: typing.Union[pathlib.Path, str],
Review comment:
```suggestion
mlf_path: typing.Union[pathlib.Path, str],
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #9090: [microTVM] Add wrapper for creating project using a MLF
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #9090:
URL: https://github.com/apache/tvm/pull/9090#issuecomment-930236057
@areusch @Mousius Thanks for the reviews. Sorry for the respin delay. I've fixed the offending line to satisfy the linter and also fixed the type hints for the added function (s/typing.Union/Union/) I think CI haven't caught it because the code is not being used currently -- I found that when using the code on my tvmc micro work. Hopefully https://github.com/apache/tvm/pull/9090/commits/7f6da2c167c053ad11c32464c48515595d0a4bec will be all right for the CI. Cheers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero edited a comment on pull request #9090: [microTVM] Add wrapper for creating project using a MLF
Posted by GitBox <gi...@apache.org>.
gromero edited a comment on pull request #9090:
URL: https://github.com/apache/tvm/pull/9090#issuecomment-925810172
cc @areusch @mehrdadh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org