You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "justinrsweeney (via GitHub)" <gi...@apache.org> on 2023/03/08 14:40:53 UTC
[GitHub] [solr] justinrsweeney opened a new pull request, #1442: Improving efficiency of replication process
justinrsweeney opened a new pull request, #1442:
URL: https://github.com/apache/solr/pull/1442
https://issues.apache.org/jira/browse/SOLR-16689
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
This PR resolves two inefficiencies in the replication process:
1. Avoiding repeated attempts to replicate an empty index
2. Avoiding an unnecessary commit call to leader when replicating to a PULL replica
# Solution
Fixed the check of an empty index to use commit timestamp equal to 0 as opposed to generation which starts at 1.
Added a check when a replica is recovering to only commit the leader if the recovering replica is a leader type. PULL replicas which cannot become leader, do not need to force a commit on the leader in order to recover.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] justinrsweeney merged pull request #1442: Improving efficiency of replication process
Posted by "justinrsweeney (via GitHub)" <gi...@apache.org>.
justinrsweeney merged PR #1442:
URL: https://github.com/apache/solr/pull/1442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1442: Improving efficiency of replication process
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on code in PR #1442:
URL: https://github.com/apache/solr/pull/1442#discussion_r1131466824
##########
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##########
@@ -223,8 +223,10 @@ private final void replicate(String nodeName, SolrCore core, ZkNodeProps leaderp
log.info("Attempting to replicate from [{}].", leaderUrl);
- // send commit
- commitOnLeader(leaderUrl);
+ // send commit if replica could be a leader
+ if (replicaType == null || Replica.Type.isLeaderType(replicaType)) {
Review Comment:
minor: `Replica.Type.isLeaderType` could also check for null and make this logic clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org