[jira] [Closed] (WICKET-4931) Session #invalidate() then #bind() will unintentionally destroy it at end of request

["Sven Meier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sven Meier closed WICKET-4931.
------------------------------

    Resolution: Invalid

You're right, a stateful page would always re-bind the session :/.
                
> Session #invalidate() then #bind() will unintentionally destroy it at end of request 
> -------------------------------------------------------------------------------------
>
>                 Key: WICKET-4931
>                 URL: https://issues.apache.org/jira/browse/WICKET-4931
>             Project: Wicket
>          Issue Type: Improvement
>    Affects Versions: 6.4.0
>            Reporter: Sven Meier
>             Fix For: 7.0
>
>
> diff --git a/wicket-core/src/main/java/org/apache/wicket/Session.java b/wicket-core/src/main/java/org/apache/wicket/Session.java
> index 3f2ba31..090af1a 100644
> --- a/wicket-core/src/main/java/org/apache/wicket/Session.java
> +++ b/wicket-core/src/main/java/org/apache/wicket/Session.java
> @@ -231,6 +231,8 @@
>  	 * available in next requests. If the session was already bound (
>  	 * {@link ISessionStore#lookup(Request) returns a session}), this call will be a noop.
>  	 * </p>
> +	 * A former invalidation of this session is cancelled, thus it is no longer {@link #destroy()}ed
> +	 * at the end of the request.
>  	 */
>  	public final void bind()
>  	{
> @@ -259,6 +261,8 @@
>  				temporarySessionAttributes = null;
>  			}
>  		}
> +
> +		sessionInvalidated = false;
>  	}
>  
>  	/**

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira