You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Karthiga Rajeevani Ratnam (JIRA)" <ji...@apache.org> on 2007/03/21 08:07:32 UTC
[jira] Created: (AXIS2-2358) Code level Comments
Code level Comments
-------------------
Key: AXIS2-2358
URL: https://issues.apache.org/jira/browse/AXIS2-2358
Project: Axis 2.0 (Axis2)
Issue Type: Improvement
Components: documentation
Affects Versions: 1.2
Environment: Linux
Reporter: Karthiga Rajeevani Ratnam
Fix For: 1.2
Improvements made to inline code level comments on AddressingBasedDispatcher.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-2358) Code level Comments
Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepal Jayasinghe updated AXIS2-2358:
-------------------------------------
Fix Version/s: (was: 1.2)
nightly
> Code level Comments
> -------------------
>
> Key: AXIS2-2358
> URL: https://issues.apache.org/jira/browse/AXIS2-2358
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 1.2
> Environment: Linux
> Reporter: Karthiga Rajeevani Ratnam
> Fix For: nightly
>
> Attachments: patch
>
>
> Improvements made to inline code level comments on AddressingBasedDispatcher.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-2358) Code level Comments
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Davanum Srinivas updated AXIS2-2358:
------------------------------------
Assignee: Thilina Gunarathne
> Code level Comments
> -------------------
>
> Key: AXIS2-2358
> URL: https://issues.apache.org/jira/browse/AXIS2-2358
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 1.2
> Environment: Linux
> Reporter: Karthiga Rajeevani Ratnam
> Assignee: Thilina Gunarathne
> Fix For: nightly
>
> Attachments: patch
>
>
> Improvements made to inline code level comments on AddressingBasedDispatcher.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Resolved: (AXIS2-2358) Code level Comments
Posted by "Glen Daniels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Glen Daniels resolved AXIS2-2358.
---------------------------------
Resolution: Invalid
Marked as "invalid" for now since the patch doesn't match the source anymore. Please reopen with a new patch if you like.
> Code level Comments
> -------------------
>
> Key: AXIS2-2358
> URL: https://issues.apache.org/jira/browse/AXIS2-2358
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 1.3
> Environment: Linux
> Reporter: Karthiga Rajeevani Ratnam
> Assignee: Thilina Gunarathne
> Attachments: patch
>
>
> Improvements made to inline code level comments on AddressingBasedDispatcher.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Resolved: (AXIS2-2358) Code level Comments
Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepal Jayasinghe resolved AXIS2-2358.
--------------------------------------
Resolution: Fixed
patch is outdated
> Code level Comments
> -------------------
>
> Key: AXIS2-2358
> URL: https://issues.apache.org/jira/browse/AXIS2-2358
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 1.3
> Environment: Linux
> Reporter: Karthiga Rajeevani Ratnam
> Assignee: Thilina Gunarathne
> Attachments: patch
>
>
> Improvements made to inline code level comments on AddressingBasedDispatcher.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-2358) Code level Comments
Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Deepal Jayasinghe updated AXIS2-2358:
-------------------------------------
Affects Version/s: (was: 1.2)
1.3
Fix Version/s: (was: nightly)
1.3
Need to apply the patch.
> Code level Comments
> -------------------
>
> Key: AXIS2-2358
> URL: https://issues.apache.org/jira/browse/AXIS2-2358
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 1.3
> Environment: Linux
> Reporter: Karthiga Rajeevani Ratnam
> Assignee: Thilina Gunarathne
> Fix For: 1.3
>
> Attachments: patch
>
>
> Improvements made to inline code level comments on AddressingBasedDispatcher.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-2358) Code level Comments
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Davanum Srinivas updated AXIS2-2358:
------------------------------------
Fix Version/s: (was: 1.3)
> Code level Comments
> -------------------
>
> Key: AXIS2-2358
> URL: https://issues.apache.org/jira/browse/AXIS2-2358
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 1.3
> Environment: Linux
> Reporter: Karthiga Rajeevani Ratnam
> Assignee: Thilina Gunarathne
> Attachments: patch
>
>
> Improvements made to inline code level comments on AddressingBasedDispatcher.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-2358) Code level Comments
Posted by "Thilina Gunarathne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483031 ]
Thilina Gunarathne commented on AXIS2-2358:
-------------------------------------------
>- // If the axisService is not null we get the binding that the request came to add
>- // add it as a property to the messageContext
>+ // If the axisService is not null, the binding that the request came to add is obtained.
>+ // Add endpoints as a property to the messageContext
At least the above change does not look right to me.. The current version in the source code which is given below looks better than that to me...
// If the axisService is not null we get the binding that the request came to and
// add it as a property to the messageContext
> Code level Comments
> -------------------
>
> Key: AXIS2-2358
> URL: https://issues.apache.org/jira/browse/AXIS2-2358
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 1.2
> Environment: Linux
> Reporter: Karthiga Rajeevani Ratnam
> Fix For: 1.2
>
> Attachments: patch
>
>
> Improvements made to inline code level comments on AddressingBasedDispatcher.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-2358) Code level Comments
Posted by "Karthiga Rajeevani Ratnam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karthiga Rajeevani Ratnam updated AXIS2-2358:
---------------------------------------------
Attachment: patch
Inline code level comments for AddressingBasedDispatcher.java
> Code level Comments
> -------------------
>
> Key: AXIS2-2358
> URL: https://issues.apache.org/jira/browse/AXIS2-2358
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 1.2
> Environment: Linux
> Reporter: Karthiga Rajeevani Ratnam
> Fix For: 1.2
>
> Attachments: patch
>
>
> Improvements made to inline code level comments on AddressingBasedDispatcher.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-2358) Code level Comments
Posted by "Karthiga Rajeevani Ratnam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484010 ]
Karthiga Rajeevani Ratnam commented on AXIS2-2358:
--------------------------------------------------
I got this straight from an Axis 2 developer. I apologise of there is a mistake and check back.
> Code level Comments
> -------------------
>
> Key: AXIS2-2358
> URL: https://issues.apache.org/jira/browse/AXIS2-2358
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 1.2
> Environment: Linux
> Reporter: Karthiga Rajeevani Ratnam
> Fix For: 1.2
>
> Attachments: patch
>
>
> Improvements made to inline code level comments on AddressingBasedDispatcher.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Reopened: (AXIS2-2358) Code level Comments
Posted by "Glen Daniels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Glen Daniels reopened AXIS2-2358:
---------------------------------
If the patch is outdated, it's not fixed.
> Code level Comments
> -------------------
>
> Key: AXIS2-2358
> URL: https://issues.apache.org/jira/browse/AXIS2-2358
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 1.3
> Environment: Linux
> Reporter: Karthiga Rajeevani Ratnam
> Assignee: Thilina Gunarathne
> Attachments: patch
>
>
> Improvements made to inline code level comments on AddressingBasedDispatcher.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org