[GitHub] [trafficcontrol] traeak commented on a change in pull request #4343: traffic_ops_ort: fix for syncds having too many header rewrite false …

[GitBox <gi...@apache.org>]

traeak commented on a change in pull request #4343: traffic_ops_ort: fix for syncds having too many header rewrite false …
URL: https://github.com/apache/trafficcontrol/pull/4343#discussion_r372537498
 
 

 ##########
 File path: traffic_ops/ort/traffic_ops_ort.pl
 ##########
 @@ -2652,6 +2658,23 @@ sub scrape_unencode_text {
 	return \@lines;
 }
 
+sub scrape_canned_comments {
+	my $linesin = $_[0];
+
+	my @linesout;
+
+	foreach my $line (@$linesin) {
+		if ( $line =~ m/^\#/ ) {
+			if ( $line =~ m/DO NOT EDIT - Generated for / || $line =~ m/$header_comment/ || $line =~ m/TRAFFIC OPS NOTE\:/ || $line =~ m/^##OVERRID.*##/ ) {
 
 Review comment:
   This function applies not just to ats config files but also to other type files that may not use '#' as a comment convention.  This is part of the hackery that is ORT.  Honestly I'm a bit scared about increasing scope of the changes.  You'll notice code that's left over is now checking for things that have already been stripped.  How much refactoring should be done?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services