You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/08/24 13:48:09 UTC
Review Request 68503: Replaced boost includes with stout equivalents.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68503/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
Repository: mesos
Description
-------
Replaced usages of `boost::circular_buffer` with the equivalent
`circular_buffer` from stout in both master and slave.
Diffs
-----
src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
src/slave/slave.hpp 0420109ac93e1249906c52437e5859c5ee033fb6
Diff: https://reviews.apache.org/r/68503/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68503: Replaced boost includes with stout
equivalents.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68503/#review207897
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On Aug. 24, 2018, 3:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68503/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 3:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced usages of `boost::circular_buffer` with the equivalent
> `circular_buffer` from stout in both master and slave.
>
>
> Diffs
> -----
>
> src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
> src/slave/slave.hpp 0420109ac93e1249906c52437e5859c5ee033fb6
>
>
> Diff: https://reviews.apache.org/r/68503/diff/1/
>
>
> Testing
> -------
>
> - Repeated the procedure described in https://reviews.apache.org/r/68484
> - `make check`
> - Internal CI run. (Build #4239)
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68503: Replaced boost includes with stout
equivalents.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68503/#review207908
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68484, 68502, 68503]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 24, 2018, 3:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68503/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 3:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced usages of `boost::circular_buffer` with the equivalent
> `circular_buffer` from stout in both master and slave.
>
>
> Diffs
> -----
>
> src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
> src/slave/slave.hpp 0420109ac93e1249906c52437e5859c5ee033fb6
>
>
> Diff: https://reviews.apache.org/r/68503/diff/1/
>
>
> Testing
> -------
>
> - Repeated the procedure described in https://reviews.apache.org/r/68484
> - `make check`
> - Internal CI run. (Build #4239)
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68503: Replaced boost includes with stout
equivalents.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68503/#review207910
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/slave.hpp
Line 1048 (original), 1044 (patched)
<https://reviews.apache.org/r/68503/#comment291537>
Could you also adjust the assignment in `src/slave/slave.cpp:9616`?
- Benjamin Bannier
On Aug. 24, 2018, 5:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68503/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced usages of `boost::circular_buffer` with the equivalent
> `circular_buffer` from stout in both master and slave.
>
>
> Diffs
> -----
>
> src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
> src/slave/slave.hpp 0420109ac93e1249906c52437e5859c5ee033fb6
>
>
> Diff: https://reviews.apache.org/r/68503/diff/1/
>
>
> Testing
> -------
>
> - Repeated the procedure described in https://reviews.apache.org/r/68484
> - `make check`
> - Internal CI run. (Build #4239)
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68503: Replaced boost includes with stout
equivalents.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68503/
-----------------------------------------------------------
(Updated Aug. 24, 2018, 3:40 p.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
Repository: mesos
Description
-------
Replaced usages of `boost::circular_buffer` with the equivalent
`circular_buffer` from stout in both master and slave.
Diffs
-----
src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
src/slave/slave.hpp 0420109ac93e1249906c52437e5859c5ee033fb6
Diff: https://reviews.apache.org/r/68503/diff/1/
Testing (updated)
-------
- Repeated the procedure described in https://reviews.apache.org/r/68484
- `make check`
- Internal CI run. (Build #4239)
Thanks,
Benno Evers
Re: Review Request 68503: Replaced boost includes with stout
equivalents.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68503/#review207888
-----------------------------------------------------------
PASS: Mesos patch 68503 was successfully built and tested.
Reviews applied: `['68484', '68502', '68503']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2235/mesos-review-68503
- Mesos Reviewbot Windows
On Aug. 24, 2018, 1:48 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68503/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 1:48 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced usages of `boost::circular_buffer` with the equivalent
> `circular_buffer` from stout in both master and slave.
>
>
> Diffs
> -----
>
> src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8
> src/slave/slave.hpp 0420109ac93e1249906c52437e5859c5ee033fb6
>
>
> Diff: https://reviews.apache.org/r/68503/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>