You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by su...@apache.org on 2015/01/15 01:34:52 UTC
trafficserver git commit: [TS-3294]: Move dereference after null check
Repository: trafficserver
Updated Branches:
refs/heads/master 0e88a2f7d -> c22266848
[TS-3294]: Move dereference after null check
Coverity CID#1237321
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/c2226684
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/c2226684
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/c2226684
Branch: refs/heads/master
Commit: c22266848846a696b081bd98f1b4c4dcce7e9aa2
Parents: 0e88a2f
Author: Sudheer Vinukonda <su...@yahoo-inc.com>
Authored: Thu Jan 15 00:34:15 2015 +0000
Committer: Sudheer Vinukonda <su...@yahoo-inc.com>
Committed: Thu Jan 15 00:34:15 2015 +0000
----------------------------------------------------------------------
mgmt/api/CoreAPIRemote.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/c2226684/mgmt/api/CoreAPIRemote.cc
----------------------------------------------------------------------
diff --git a/mgmt/api/CoreAPIRemote.cc b/mgmt/api/CoreAPIRemote.cc
index 67de06f..cc462d8 100644
--- a/mgmt/api/CoreAPIRemote.cc
+++ b/mgmt/api/CoreAPIRemote.cc
@@ -150,12 +150,12 @@ mgmt_record_set(const char *rec_name, const char *rec_val, TSActionNeedT * actio
MgmtMarshallInt err;
MgmtMarshallInt action = TS_ACTION_UNDEFINED;
- *action_need = TS_ACTION_UNDEFINED;
-
if (!rec_name || !rec_val || !action_need) {
return TS_ERR_PARAMS;
}
+ *action_need = TS_ACTION_UNDEFINED;
+
// create and send request
ret = MGMTAPI_SEND_MESSAGE(main_socket_fd, RECORD_SET, &optype, &name, &value);
if (ret != TS_ERR_OKAY) {