You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2021/11/14 19:57:30 UTC
[GitHub] [jmeter] pmouawad opened a new pull request #677: Align ssl props / Enable setting cipher suite (WIP)
pmouawad opened a new pull request #677:
URL: https://github.com/apache/jmeter/pull/677
## Description
- Use https.cipherSuites property for HC4
- Use https.cipherSuites and https.socket.protocols in Proxy
## Motivation and Context
Clarification of use.
Allow fine grain control during recording.
## How Has This Been Tested?
Manual testing and debugging.
## Types of changes
- Bug fix (non-breaking change which fixes an issue)
## Checklist:
- [X] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] codecov-commenter commented on pull request #677: Align ssl props / Enable setting cipher suite (WIP)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #677:
URL: https://github.com/apache/jmeter/pull/677#issuecomment-974664202
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#677](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9717ffd) into [master](https://codecov.io/gh/apache/jmeter/commit/3c23246558a56e751f3e4fd860f46a2440893fa8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c23246) will **increase** coverage by `0.25%`.
> The diff coverage is `27.69%`.
[](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #677 +/- ##
============================================
+ Coverage 55.40% 55.66% +0.25%
- Complexity 10230 10283 +53
============================================
Files 1047 1049 +2
Lines 64518 64565 +47
Branches 7317 7321 +4
============================================
+ Hits 35749 35937 +188
+ Misses 26271 26105 -166
- Partials 2498 2523 +25
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...AddUndoableEditListenerPropertyChangeListener.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2pvcnBoYW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2pvcnBoYW4vZ3VpL3VpL0FkZFVuZG9hYmxlRWRpdExpc3RlbmVyUHJvcGVydHlDaGFuZ2VMaXN0ZW5lci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/jorphan/gui/ui/DefaultUndoManager.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2pvcnBoYW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2pvcnBoYW4vZ3VpL3VpL0RlZmF1bHRVbmRvTWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/jmeter/protocol/http/proxy/Proxy.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3Byb3RvY29sL2h0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9odHRwL3Byb3h5L1Byb3h5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ava/org/apache/jorphan/gui/ui/TextComponentUI.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2pvcnBoYW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2pvcnBoYW4vZ3VpL3VpL1RleHRDb21wb25lbnRVSS5qYXZh) | `26.82% <18.75%> (+26.82%)` | :arrow_up: |
| [.../main/java/org/apache/jmeter/util/JMeterUtils.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci91dGlsL0pNZXRlclV0aWxzLmphdmE=) | `54.23% <71.42%> (+2.86%)` | :arrow_up: |
| [...va/org/apache/jmeter/gui/util/JSyntaxTextArea.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9ndWkvdXRpbC9KU3ludGF4VGV4dEFyZWEuamF2YQ==) | `61.53% <100.00%> (+0.42%)` | :arrow_up: |
| [...sampler/hc/LazyLayeredConnectionSocketFactory.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3Byb3RvY29sL2h0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9odHRwL3NhbXBsZXIvaGMvTGF6eUxheWVyZWRDb25uZWN0aW9uU29ja2V0RmFjdG9yeS5qYXZh) | `94.44% <100.00%> (+8.08%)` | :arrow_up: |
| [.../apache/jmeter/timers/ConstantThroughputTimer.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci90aW1lcnMvQ29uc3RhbnRUaHJvdWdocHV0VGltZXIuamF2YQ==) | `54.63% <0.00%> (-4.13%)` | :arrow_down: |
| [...main/java/org/apache/jmeter/config/CSVDataSet.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9jb25maWcvQ1NWRGF0YVNldC5qYXZh) | `78.81% <0.00%> (-3.39%)` | :arrow_down: |
| [...e/jmeter/save/converters/TestElementConverter.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9zYXZlL2NvbnZlcnRlcnMvVGVzdEVsZW1lbnRDb252ZXJ0ZXIuamF2YQ==) | `75.55% <0.00%> (-3.02%)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [062190a...9717ffd](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on a change in pull request #677: Align ssl props / Enable setting cipher suite (WIP)
Posted by GitBox <gi...@apache.org>.
vlsi commented on a change in pull request #677:
URL: https://github.com/apache/jmeter/pull/677#discussion_r748907085
##########
File path: src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/Proxy.java
##########
@@ -89,6 +89,19 @@
private static final String SSLCONTEXT_PROTOCOL =
JMeterUtils.getPropDefault("proxy.ssl.protocol", "TLS"); // $NON-NLS-1$ $NON-NLS-2$
+ private static final String PROTOCOL_LIST =
+ JMeterUtils.getPropDefault("https.socket.protocols", ""); // $NON-NLS-1$ $NON-NLS-2$
+
+ private static final String CIPHER_SUITE_LIST =
+ JMeterUtils.getPropDefault("https.cipherSuites", ""); // $NON-NLS-1$ $NON-NLS-2$
+
+ private static final String[] SUPPORTED_PROTOCOL_LIST =
Review comment:
The naming looks misleading.
What do you think if `String PROTOCOL_LIST` was named `String HTTPS_SOCKET_PROTOCOLS`, and `String[] SUPPORTED_PROTOCOL_LIST` was `String[] HTTPS_SOCKET_PROTOCOLS_ARRAY`?
On the other hand, it might make sense to add `JMeterUtils.getArrayPropDefault` or something like that since it is probably not the last time we have an array property. It would eliminate the need of non-array field (so there would not be a need to invent a name for it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] pmouawad merged pull request #677: Align ssl props / Enable setting cipher suite (WIP)
Posted by GitBox <gi...@apache.org>.
pmouawad merged pull request #677:
URL: https://github.com/apache/jmeter/pull/677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] codecov-commenter commented on pull request #677: Align ssl props / Enable setting cipher suite (WIP)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #677:
URL: https://github.com/apache/jmeter/pull/677#issuecomment-974664202
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#677](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9717ffd) into [master](https://codecov.io/gh/apache/jmeter/commit/3c23246558a56e751f3e4fd860f46a2440893fa8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c23246) will **increase** coverage by `0.25%`.
> The diff coverage is `27.69%`.
[](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #677 +/- ##
============================================
+ Coverage 55.40% 55.66% +0.25%
- Complexity 10230 10283 +53
============================================
Files 1047 1049 +2
Lines 64518 64565 +47
Branches 7317 7321 +4
============================================
+ Hits 35749 35937 +188
+ Misses 26271 26105 -166
- Partials 2498 2523 +25
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...AddUndoableEditListenerPropertyChangeListener.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2pvcnBoYW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2pvcnBoYW4vZ3VpL3VpL0FkZFVuZG9hYmxlRWRpdExpc3RlbmVyUHJvcGVydHlDaGFuZ2VMaXN0ZW5lci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/jorphan/gui/ui/DefaultUndoManager.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2pvcnBoYW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2pvcnBoYW4vZ3VpL3VpL0RlZmF1bHRVbmRvTWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/jmeter/protocol/http/proxy/Proxy.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3Byb3RvY29sL2h0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9odHRwL3Byb3h5L1Byb3h5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ava/org/apache/jorphan/gui/ui/TextComponentUI.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2pvcnBoYW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2pvcnBoYW4vZ3VpL3VpL1RleHRDb21wb25lbnRVSS5qYXZh) | `26.82% <18.75%> (+26.82%)` | :arrow_up: |
| [.../main/java/org/apache/jmeter/util/JMeterUtils.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci91dGlsL0pNZXRlclV0aWxzLmphdmE=) | `54.23% <71.42%> (+2.86%)` | :arrow_up: |
| [...va/org/apache/jmeter/gui/util/JSyntaxTextArea.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9ndWkvdXRpbC9KU3ludGF4VGV4dEFyZWEuamF2YQ==) | `61.53% <100.00%> (+0.42%)` | :arrow_up: |
| [...sampler/hc/LazyLayeredConnectionSocketFactory.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3Byb3RvY29sL2h0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9odHRwL3NhbXBsZXIvaGMvTGF6eUxheWVyZWRDb25uZWN0aW9uU29ja2V0RmFjdG9yeS5qYXZh) | `94.44% <100.00%> (+8.08%)` | :arrow_up: |
| [.../apache/jmeter/timers/ConstantThroughputTimer.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci90aW1lcnMvQ29uc3RhbnRUaHJvdWdocHV0VGltZXIuamF2YQ==) | `54.63% <0.00%> (-4.13%)` | :arrow_down: |
| [...main/java/org/apache/jmeter/config/CSVDataSet.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9jb25maWcvQ1NWRGF0YVNldC5qYXZh) | `78.81% <0.00%> (-3.39%)` | :arrow_down: |
| [...e/jmeter/save/converters/TestElementConverter.java](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9zYXZlL2NvbnZlcnRlcnMvVGVzdEVsZW1lbnRDb252ZXJ0ZXIuamF2YQ==) | `75.55% <0.00%> (-3.02%)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/jmeter/pull/677/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [062190a...9717ffd](https://codecov.io/gh/apache/jmeter/pull/677?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on a change in pull request #677: Align ssl props / Enable setting cipher suite (WIP)
Posted by GitBox <gi...@apache.org>.
vlsi commented on a change in pull request #677:
URL: https://github.com/apache/jmeter/pull/677#discussion_r748906691
##########
File path: src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/Proxy.java
##########
@@ -89,6 +89,19 @@
private static final String SSLCONTEXT_PROTOCOL =
JMeterUtils.getPropDefault("proxy.ssl.protocol", "TLS"); // $NON-NLS-1$ $NON-NLS-2$
+ private static final String PROTOCOL_LIST =
+ JMeterUtils.getPropDefault("https.socket.protocols", ""); // $NON-NLS-1$ $NON-NLS-2$
+
+ private static final String CIPHER_SUITE_LIST =
+ JMeterUtils.getPropDefault("https.cipherSuites", ""); // $NON-NLS-1$ $NON-NLS-2$
+
+ private static final String[] SUPPORTED_PROTOCOL_LIST =
+ PROTOCOL_LIST.isEmpty() ?
+ null: PROTOCOL_LIST.split(" "); // $NON-NLS-1$
Review comment:
What do you think if trim the value first, and then split with `\\s+` pattern? In other words, allow multiple whitespace as a separator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on a change in pull request #677: Align ssl props / Enable setting cipher suite (WIP)
Posted by GitBox <gi...@apache.org>.
vlsi commented on a change in pull request #677:
URL: https://github.com/apache/jmeter/pull/677#discussion_r753699684
##########
File path: src/core/src/main/java/org/apache/jmeter/util/JMeterUtils.java
##########
@@ -713,6 +714,27 @@ public static boolean getPropDefault(String propName, boolean defaultVal) {
return defaultVal;
}
+ /**
+ * Get an array of String if present and not empty, defaultValue if not present.
+ *
+ * @param propName
+ * the name of the property.
+ * @param defaultVal
+ * the default value.
+ * @return The PropDefault value
+ */
+ public static String[] getArrayPropDefault(String propName, String[] defaultVal) {
+ try {
+ String strVal = appProperties.getProperty(propName);
+ if (StringUtils.isNotBlank(strVal)) {
+ return strVal.trim().split("\\s+");
+ }
+ } catch (Exception e) {
+ log.warn("Exception '{}' occurred when fetching boolean property:'{}', defaulting to: {}", e.getMessage(), propName, defaultVal);
Review comment:
String[].toString() is useless. Please use Arrays.toString(...)
Does it make sense to pass the exception for printing the stacktrace as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] pmouawad merged pull request #677: Align ssl props / Enable setting cipher suite (WIP)
Posted by GitBox <gi...@apache.org>.
pmouawad merged pull request #677:
URL: https://github.com/apache/jmeter/pull/677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on a change in pull request #677: Align ssl props / Enable setting cipher suite (WIP)
Posted by GitBox <gi...@apache.org>.
vlsi commented on a change in pull request #677:
URL: https://github.com/apache/jmeter/pull/677#discussion_r753699684
##########
File path: src/core/src/main/java/org/apache/jmeter/util/JMeterUtils.java
##########
@@ -713,6 +714,27 @@ public static boolean getPropDefault(String propName, boolean defaultVal) {
return defaultVal;
}
+ /**
+ * Get an array of String if present and not empty, defaultValue if not present.
+ *
+ * @param propName
+ * the name of the property.
+ * @param defaultVal
+ * the default value.
+ * @return The PropDefault value
+ */
+ public static String[] getArrayPropDefault(String propName, String[] defaultVal) {
+ try {
+ String strVal = appProperties.getProperty(propName);
+ if (StringUtils.isNotBlank(strVal)) {
+ return strVal.trim().split("\\s+");
+ }
+ } catch (Exception e) {
+ log.warn("Exception '{}' occurred when fetching boolean property:'{}', defaulting to: {}", e.getMessage(), propName, defaultVal);
Review comment:
String[].toString() is useless. Please use Arrays.toString(...)
Does it make sense to pass the exception for printing the stacktrace as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org