You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/09 07:28:50 UTC
[GitHub] [spark] Ngone51 opened a new pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Ngone51 opened a new pull request #29050:
URL: https://github.com/apache/spark/pull/29050
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to use `Utils.getSimpleName(function)` instead of `function.getClass.getSimpleName` to get the class name.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
For some functions(see the demo below), using `function.getClass.getSimpleName` can hit "Malformed class name" error.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. For the demo,
```scala
object MalformedClassObject extends Serializable {
class MalformedNonPrimitiveFunction extends (String => Int) with Serializable {
override def apply(v1: String): Int = v1.toInt / 0
}
}
OuterScopes.addOuterScope(MalformedClassObject)
val f = new MalformedClassObject.MalformedNonPrimitiveFunction()
Seq("20").toDF("col").select(udf(f).apply(Column("col"))).collect()
```
Before this PR, user can only see the error about "Malformed class name":
```scala
An exception or error caused a run to abort: Malformed class name
java.lang.InternalError: Malformed class name
at java.lang.Class.getSimpleName(Class.java:1330)
at org.apache.spark.sql.catalyst.expressions.ScalaUDF.udfErrorMessage$lzycompute(ScalaUDF.scala:1157)
at org.apache.spark.sql.catalyst.expressions.ScalaUDF.udfErrorMessage(ScalaUDF.scala:1155)
at org.apache.spark.sql.catalyst.expressions.ScalaUDF.doGenCode(ScalaUDF.scala:1077)
at org.apache.spark.sql.catalyst.expressions.Expression.$anonfun$genCode$3(Expression.scala:147)
at scala.Option.getOrElse(Option.scala:189)
at org.apache.spark.sql.catalyst.expressions.Expression.genCode(Expression.scala:142)
at org.apache.spark.sql.catalyst.expressions.Alias.genCode(namedExpressions.scala:160)
at org.apache.spark.sql.execution.ProjectExec.$anonfun$doConsume$1(basicPhysicalOperators.scala:69)
...
```
After this PR, user can see the real root cause of the udf failure:
```scala
org.apache.spark.SparkException: Failed to execute user defined function(UDFSuite$MalformedClassObject$MalformedNonPrimitiveFunction: (string) => int)
at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.processNext(Unknown Source)
at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
at org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:753)
at org.apache.spark.sql.execution.SparkPlan.$anonfun$getByteArrayRdd$1(SparkPlan.scala:340)
at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2(RDD.scala:898)
at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2$adapted(RDD.scala:898)
at org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:52)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:373)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:337)
at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
at org.apache.spark.scheduler.Task.run(Task.scala:127)
at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:464)
at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1377)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:467)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ArithmeticException: / by zero
at org.apache.spark.sql.UDFSuite$MalformedClassObject$MalformedNonPrimitiveFunction.apply(UDFSuite.scala:677)
at org.apache.spark.sql.UDFSuite$MalformedClassObject$MalformedNonPrimitiveFunction.apply(UDFSuite.scala:676)
... 17 more
```
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added a test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656432303
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656044246
**[Test build #125451 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125451/testReport)** for PR 29050 at commit [`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` test(\"SPARK-32238: Use Utils.getSimpleName to avoid hitting Malformed class name\") `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655956720
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29050:
URL: https://github.com/apache/spark/pull/29050#discussion_r452148894
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala
##########
@@ -669,4 +671,30 @@ class UDFSuite extends QueryTest with SharedSparkSession {
val df = Seq(Array(Some(TestData(50, "2")), None)).toDF("col")
checkAnswer(df.select(myUdf(Column("col"))), Row(100) :: Nil)
}
+
+ object MalformedClassObject extends Serializable {
+ class MalformedNonPrimitiveFunction extends (String => Int) with Serializable {
+ override def apply(v1: String): Int = v1.toInt / 0
+ }
+
+ class MalformedPrimitiveFunction extends (Int => Int) with Serializable {
+ override def apply(v1: Int): Int = v1 / 0
+ }
+ }
+
+ test("SPARK-32238: Use Utils.getSimpleName to avoid hitting Malformed class name") {
+ OuterScopes.addOuterScope(MalformedClassObject)
+ val f1 = new MalformedClassObject.MalformedNonPrimitiveFunction()
+ val f2 = new MalformedClassObject.MalformedPrimitiveFunction()
Review comment:
Just a qestion; we need the two cases here for checking this issue? I mean; is either one not enough for tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656812985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29050:
URL: https://github.com/apache/spark/pull/29050#discussion_r452025662
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala
##########
@@ -669,4 +671,30 @@ class UDFSuite extends QueryTest with SharedSparkSession {
val df = Seq(Array(Some(TestData(50, "2")), None)).toDF("col")
checkAnswer(df.select(myUdf(Column("col"))), Row(100) :: Nil)
}
+
+ object MalformedClassObject extends Serializable {
+ class MalformedNonPrimitiveFunction extends (String => Int) with Serializable {
+ override def apply(v1: String): Int = v1.toInt / 0
+ }
+
+ class MalformedPrimitiveFunction extends (Int => Int) with Serializable {
+ override def apply(v1: Int): Int = v1 / 0
+ }
+ }
+
+ test("Use Utils.getSimpleName to avoid hitting Malformed class name") {
Review comment:
can we add the jira id?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29050:
URL: https://github.com/apache/spark/pull/29050
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656521928
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656812490
**[Test build #125631 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125631/testReport)** for PR 29050 at commit [`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-657062144
Thank you, @Ngone51 and all.
Merged to master/3.0/2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656163218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656871395
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125631/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656159836
**[Test build #125447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125447/testReport)** for PR 29050 at commit [`4117f99`](https://github.com/apache/spark/commit/4117f99b476d92954f667d1d6bf2d0e4ae5f5ffe).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656812490
**[Test build #125631 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125631/testReport)** for PR 29050 at commit [`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655956198
**[Test build #125447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125447/testReport)** for PR 29050 at commit [`4117f99`](https://github.com/apache/spark/commit/4117f99b476d92954f667d1d6bf2d0e4ae5f5ffe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656780129
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656433022
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656432731
**[Test build #125533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125533/testReport)** for PR 29050 at commit [`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655956720
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656871382
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656558577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656994869
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656869941
**[Test build #125631 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125631/testReport)** for PR 29050 at commit [`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` test(\"SPARK-32238: Use Utils.getSimpleName to avoid hitting Malformed class name\") `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655956198
**[Test build #125447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125447/testReport)** for PR 29050 at commit [`4117f99`](https://github.com/apache/spark/commit/4117f99b476d92954f667d1d6bf2d0e4ae5f5ffe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655964561
**[Test build #125451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125451/testReport)** for PR 29050 at commit [`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656046217
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #29050:
URL: https://github.com/apache/spark/pull/29050#discussion_r452026471
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala
##########
@@ -669,4 +671,30 @@ class UDFSuite extends QueryTest with SharedSparkSession {
val df = Seq(Array(Some(TestData(50, "2")), None)).toDF("col")
checkAnswer(df.select(myUdf(Column("col"))), Row(100) :: Nil)
}
+
+ object MalformedClassObject extends Serializable {
+ class MalformedNonPrimitiveFunction extends (String => Int) with Serializable {
+ override def apply(v1: String): Int = v1.toInt / 0
+ }
+
+ class MalformedPrimitiveFunction extends (Int => Int) with Serializable {
+ override def apply(v1: Int): Int = v1 / 0
+ }
+ }
+
+ test("Use Utils.getSimpleName to avoid hitting Malformed class name") {
Review comment:
yes, added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655955330
cc @cloud-fan @maropu @viirya Please take a look, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656521949
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125533/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656163218
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656432731
**[Test build #125533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125533/testReport)** for PR 29050 at commit [`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656780129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656811295
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656994520
**[Test build #125641 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125641/testReport)** for PR 29050 at commit [`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` test(\"SPARK-32238: Use Utils.getSimpleName to avoid hitting Malformed class name\") `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656046217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656458232
@dongjoon-hyun Ok, I've changed it to `Bug`. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656994869
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656521928
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656433022
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656558577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656557512
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656889118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29050:
URL: https://github.com/apache/spark/pull/29050#discussion_r452148894
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala
##########
@@ -669,4 +671,30 @@ class UDFSuite extends QueryTest with SharedSparkSession {
val df = Seq(Array(Some(TestData(50, "2")), None)).toDF("col")
checkAnswer(df.select(myUdf(Column("col"))), Row(100) :: Nil)
}
+
+ object MalformedClassObject extends Serializable {
+ class MalformedNonPrimitiveFunction extends (String => Int) with Serializable {
+ override def apply(v1: String): Int = v1.toInt / 0
+ }
+
+ class MalformedPrimitiveFunction extends (Int => Int) with Serializable {
+ override def apply(v1: Int): Int = v1 / 0
+ }
+ }
+
+ test("SPARK-32238: Use Utils.getSimpleName to avoid hitting Malformed class name") {
+ OuterScopes.addOuterScope(MalformedClassObject)
+ val f1 = new MalformedClassObject.MalformedNonPrimitiveFunction()
+ val f2 = new MalformedClassObject.MalformedPrimitiveFunction()
Review comment:
Just a qestion; we need the two cases here for checking the issue? I mean; is either one not enough for tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655965179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656889118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656909835
**[Test build #125641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125641/testReport)** for PR 29050 at commit [`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-657318492
Thanks all!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656909835
**[Test build #125641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125641/testReport)** for PR 29050 at commit [`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656520176
**[Test build #125533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125533/testReport)** for PR 29050 at commit [`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` test(\"SPARK-32238: Use Utils.getSimpleName to avoid hitting Malformed class name\") `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656558071
**[Test build #125583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125583/testReport)** for PR 29050 at commit [`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656163231
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125447/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29050:
URL: https://github.com/apache/spark/pull/29050#discussion_r452148894
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala
##########
@@ -669,4 +671,30 @@ class UDFSuite extends QueryTest with SharedSparkSession {
val df = Seq(Array(Some(TestData(50, "2")), None)).toDF("col")
checkAnswer(df.select(myUdf(Column("col"))), Row(100) :: Nil)
}
+
+ object MalformedClassObject extends Serializable {
+ class MalformedNonPrimitiveFunction extends (String => Int) with Serializable {
+ override def apply(v1: String): Int = v1.toInt / 0
+ }
+
+ class MalformedPrimitiveFunction extends (Int => Int) with Serializable {
+ override def apply(v1: Int): Int = v1 / 0
+ }
+ }
+
+ test("SPARK-32238: Use Utils.getSimpleName to avoid hitting Malformed class name") {
+ OuterScopes.addOuterScope(MalformedClassObject)
+ val f1 = new MalformedClassObject.MalformedNonPrimitiveFunction()
+ val f2 = new MalformedClassObject.MalformedPrimitiveFunction()
Review comment:
Just a qestion; we need the two cases here for checking this issue? I mean; one of them is not enough for tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655964561
**[Test build #125451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125451/testReport)** for PR 29050 at commit [`08749bd`](https://github.com/apache/spark/commit/08749bd0c1c2e6524866c7eb8e36e3c0ffb57835).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656046222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125451/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #29050:
URL: https://github.com/apache/spark/pull/29050#discussion_r452600574
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala
##########
@@ -669,4 +671,30 @@ class UDFSuite extends QueryTest with SharedSparkSession {
val df = Seq(Array(Some(TestData(50, "2")), None)).toDF("col")
checkAnswer(df.select(myUdf(Column("col"))), Row(100) :: Nil)
}
+
+ object MalformedClassObject extends Serializable {
+ class MalformedNonPrimitiveFunction extends (String => Int) with Serializable {
+ override def apply(v1: String): Int = v1.toInt / 0
+ }
+
+ class MalformedPrimitiveFunction extends (Int => Int) with Serializable {
+ override def apply(v1: Int): Int = v1 / 0
+ }
+ }
+
+ test("SPARK-32238: Use Utils.getSimpleName to avoid hitting Malformed class name") {
+ OuterScopes.addOuterScope(MalformedClassObject)
+ val f1 = new MalformedClassObject.MalformedNonPrimitiveFunction()
+ val f2 = new MalformedClassObject.MalformedPrimitiveFunction()
Review comment:
It should be enough. But just want to improve test coverage on both non-primitive and primitive types for Scala UDF.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-655965179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656812985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656780136
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125583/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656887863
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29050: [SPARK-32238][SQL] Use Utils.getSimpleName to avoid hitting Malformed class name in ScalaUDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29050:
URL: https://github.com/apache/spark/pull/29050#issuecomment-656871382
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org