You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2011/04/12 00:03:05 UTC

[jira] [Created] (MAPREDUCE-2431) MR-279: re-enable Avro RPC tests

MR-279: re-enable Avro RPC tests
--------------------------------

                 Key: MAPREDUCE-2431
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2431
             Project: Hadoop Map/Reduce
          Issue Type: Improvement
            Reporter: Doug Cutting


MAPREDUCE-2414 added Protobuf as an RPC serialization to the MAPREDUCE-279 branch.  In doing so, it disabled unit tests for the Avro-based RPC serialization in that branch.  This issue proposes to re-enable those tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-2431) MR-279: re-enable Avro RPC tests

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated MAPREDUCE-2431:
------------------------------------

    Status: Patch Available  (was: Open)

> MR-279: re-enable Avro RPC tests
> --------------------------------
>
>                 Key: MAPREDUCE-2431
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2431
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>         Attachments: MAPREDUCE-2431.patch
>
>
> MAPREDUCE-2414 added Protobuf as an RPC serialization to the MAPREDUCE-279 branch.  In doing so, it disabled unit tests for the Avro-based RPC serialization in that branch.  This issue proposes to re-enable those tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2431) MR-279: re-enable Avro RPC tests

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027858#comment-13027858 ] 

Doug Cutting commented on MAPREDUCE-2431:
-----------------------------------------

I think the tests fail because Apache Hudson doesn't work on the MR-279 branch.

The Avro impls of the generic interfaces were all present when MAPREDUCE-2414 was committed and when I contributed this patch.  If you've chosen to abandon the use of Avro in this project, then perhaps you should make that clear and explain the rationale?  Thanks!

> MR-279: re-enable Avro RPC tests
> --------------------------------
>
>                 Key: MAPREDUCE-2431
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2431
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>         Attachments: MAPREDUCE-2431.patch
>
>
> MAPREDUCE-2414 added Protobuf as an RPC serialization to the MAPREDUCE-279 branch.  In doing so, it disabled unit tests for the Avro-based RPC serialization in that branch.  This issue proposes to re-enable those tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2431) MR-279: re-enable Avro RPC tests

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022421#comment-13022421 ] 

Hadoop QA commented on MAPREDUCE-2431:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12476062/MAPREDUCE-2431.patch
  against trunk revision 1094093.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/176//console

This message is automatically generated.

> MR-279: re-enable Avro RPC tests
> --------------------------------
>
>                 Key: MAPREDUCE-2431
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2431
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>         Attachments: MAPREDUCE-2431.patch
>
>
> MAPREDUCE-2414 added Protobuf as an RPC serialization to the MAPREDUCE-279 branch.  In doing so, it disabled unit tests for the Avro-based RPC serialization in that branch.  This issue proposes to re-enable those tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-2431) MR-279: re-enable Avro RPC tests

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated MAPREDUCE-2431:
------------------------------------

    Attachment: MAPREDUCE-2431.patch

Here's a patch that re-enables minimal tests.  This does not yet re-enable tests of Yarn using Avro RPC, just the basic RPC test.

> MR-279: re-enable Avro RPC tests
> --------------------------------
>
>                 Key: MAPREDUCE-2431
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2431
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>         Attachments: MAPREDUCE-2431.patch
>
>
> MAPREDUCE-2414 added Protobuf as an RPC serialization to the MAPREDUCE-279 branch.  In doing so, it disabled unit tests for the Avro-based RPC serialization in that branch.  This issue proposes to re-enable those tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (MAPREDUCE-2431) MR-279: re-enable Avro RPC tests

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting reassigned MAPREDUCE-2431:
---------------------------------------

    Assignee: Doug Cutting

> MR-279: re-enable Avro RPC tests
> --------------------------------
>
>                 Key: MAPREDUCE-2431
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2431
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>         Attachments: MAPREDUCE-2431.patch
>
>
> MAPREDUCE-2414 added Protobuf as an RPC serialization to the MAPREDUCE-279 branch.  In doing so, it disabled unit tests for the Avro-based RPC serialization in that branch.  This issue proposes to re-enable those tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAPREDUCE-2431) MR-279: re-enable Avro RPC tests

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027947#comment-13027947 ] 

Arun C Murthy commented on MAPREDUCE-2431:
------------------------------------------

I applied the patch and tried running tests which failed. Someone needs to implement the Avro impls for new interfaces. Can you help?

> MR-279: re-enable Avro RPC tests
> --------------------------------
>
>                 Key: MAPREDUCE-2431
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2431
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>         Attachments: MAPREDUCE-2431.patch
>
>
> MAPREDUCE-2414 added Protobuf as an RPC serialization to the MAPREDUCE-279 branch.  In doing so, it disabled unit tests for the Avro-based RPC serialization in that branch.  This issue proposes to re-enable those tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAPREDUCE-2431) MR-279: re-enable Avro RPC tests

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated MAPREDUCE-2431:
-------------------------------------

    Status: Open  (was: Patch Available)

Doug, thanks for the patch and apologies for the delay. The unit tests fail because it needs more work - specifically, you'll need to provide avro impls of the generic interfaces. Can you please update the patch and provide them? Thanks.

> MR-279: re-enable Avro RPC tests
> --------------------------------
>
>                 Key: MAPREDUCE-2431
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2431
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>         Attachments: MAPREDUCE-2431.patch
>
>
> MAPREDUCE-2414 added Protobuf as an RPC serialization to the MAPREDUCE-279 branch.  In doing so, it disabled unit tests for the Avro-based RPC serialization in that branch.  This issue proposes to re-enable those tests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira